tabrath / binaryencoding Goto Github PK

Currently we're using Travis, Appveyor and CircleCI, which is making our builds more complex than we want. Azure Pipelines supports all the platforms that we want to support.

The Binary.Varint.Read method has incorrect results when handling values larger than int.MaxValue

Sample code

ulong src = 12345678910;
byte[] buf = Binary.Varint.GetBytes(src);
Binary.Varint.Read(buf, 0, out ulong val);

Console.WriteLine(val); // Output: 18446744073170328638
Console.WriteLine(src == val); // Output: False

The error is in the Binary.Varint.cs file at lines 184 and 235

It should be changed to the following code

// value |= (ulong)(buffer[i] << s);
value |= (ulong)buffer[i] << s;

Dependabot couldn't reach https://dotnet.myget.org/F/dotnet-core/api/v3/index.json as it timed out.

Is https://dotnet.myget.org/F/dotnet-core/api/v3/index.json accessible over the internet? If it is then this may be a transitory issue and can be ignored - Dependabot will close it on its next successful update run.

View the update logs.

The new Span type could provide some optimizations for exactly this library.

I'm installed your library from NuGet.
Version is 1.3.0

This warning message was shown when i choose platform Any CPU.

when i choose platform x64, message was disappear.

could you fix this warning message?
i want to use Any CPU. nothing warning.

thanks.