tachibanayui / arduinoexample Goto Github PK

Hi. You license this thing, so you gotta be serious. I'd just like to interject for a moment...

This thing, in LightLevelSwich.ino:

QuangamingVn (C) 2015 - 2018 
  
This code created by QuangamingVn collaborate with FRIT Club, all right covered at MIT license
Idea: Nguyen Minh Quan
Coder: Nguyen Minh Quan with help of Phan Manh
When you click the button, the LED get brighter an specific level, there are 4 light level

Almost every line in this block of comment has problems.

QuangamingVn (C) 2015 - 2018

1. "QuangamingVn" is a name of an imaginary person. Names that appear along license notices must be real names, otherwise the copyright doesn't take effect. In your case, "Nguyen Minh Quan" is the only valid one.
2. "2015 - 2018": If you just created this thing in 2018, I'm not sure why you wrote "2015". Can you explain?

This code created by QuangamingVn collaborate with FRIT Club, all right covered at MIT license

In valid English (or almost-valid English™), this would be, "This code was created by Nguyen Minh Quan with collaboration from the FRIT club. Licensed under the MIT license". I also would like to know why you decided to license this thing under the MIT license, it's just that so many people use this damn license, I wonder if they know what the license says.

When you click the button, the LED get brighter an specific level, there are 4 light level

In valid English (or almost-valid English™), this would be, "When you click the button, the LED light gets brighter. There are 4 different brightness levels."

Fix the comments in the other file too.