tacit7 / smyx Goto Github PK

Hi, I like your theme but the only edit I needed to make locally was comment out the blue line box around the inactive mode-lines.

It is confusing to me as it makes me think that the buffer with blue outlined mode-line is the active one.

Simply doing the below has resolved those confusions.

   `(mode-line-inactive
     ((,class (:foreground ,smyx-gray-7
                           :background ,smyx-gray-6))))
   ;; `(mode-line-inactive
   ;;   ((,class (:foreground ,smyx-gray-7
   ;;                         :background ,smyx-gray-6
   ;;                         :box (:line-width -1 :color ,smyx-blue-5)))))

I didn't want to fork this just because of that one edit if you also are comfortable with this edit and plan to implement this in a future update.

Thanks!

The face for comments is just like regular text.
It's not easy to quickly identify comments without looking at related text tokens.

I'd use the same greyish colour as for line numbers.

Previously there was not enough contrast for selected regions and that was improved. The comment face foreground was still white, just like normal text, thus visible when selected.

Now with a light grey for comments and a region selection which is also a bit grey, comments are not visible within a selected region.

I propose to adopt the same approach as with many themes, by just darkening a bit the line highlight colour.

Before selection

After selection, comments are invisible

Is there a way that the line numbers could be made gray or something not so bright? This is a shot from the original theme's site:

I tried to edit it myself, but I have not written a theme before, so some help would be appreciated.

Please add a README and a screenshot.

Most people don't even try a theme when they don't see a picture and basic description in the front page of the project.

ps: It's a nice theme and it works well with the terminal. I hope that you'll add some more faces once in a while (guide-key, highlight for current line, etc.) and more contrast for selected text (background + foreground).