talater / open-source-templates Goto Github PK

Current vs. Expected Behavior

This project is great and just needs a few tweaks.

1. Project's PR template isn't consistent with those generated by the project

See Eating your own dog food

 ## How Has This Been Tested?
 <!--- Please describe in detail how you tested your changes. -->
-<!--- Include details of your testing environment, tests ran to see how -->
-<!--- your change affects other areas of the code, etc. -->
+<!--- Include details of your testing environment, and the tests you ran to -->
+<!--- see how your change affects other areas of the code, etc. -->

2. 'that' instead of 'which'

The below are considered defining clauses, requiring 'that' instead of 'which'. See https://www.grammarly.com/blog/which-vs-that/

-- [ ] Bug fix (non-breaking change which fixes an issue)
-- [ ] New feature (non-breaking change which adds functionality)
+- [ ] Bug fix (non-breaking change that fixes an issue)
+- [ ] New feature (non-breaking change that adds functionality)

3. 'changes' should be capitalized in header

-## Types of changes
+## Types of Changes

The tweet button at the end of the sentence in the second bullet point on the epilogue don't appear to show up for me. At first I thought it was my adblocker, but even after disabling uBlock Origin, and refreshing the page, the button still didn't appear. However, in developer tools, there is html being loaded in the iframe, and if I follow the link in the anchor tag manually it will show a tweet button.

Expected Behavior

There should be a tweet button at the end of the second bullet point on the epilogues.

Current Behavior

No tweet button appears

Possible Solution

I'm not entirely sure how to fix this, as the data is loading in the iframe, but the button appears to not appear.

Steps to Reproduce (for bugs)

1. Go through either of the stories to the end where you see the templates
2. The tweet button will be missing from the second bullet point.

Context

I was playing around on the site after the website was linked to me by a friend. At first I thought it could be my adblock, but upon disabling the adblock and reloading the page the button was still not there, despite there being html loaded in the iframe.

Your Environment

• Version used: Current version on https://www.talater.com/open-source-templates/
• Browser Name and version: Chrome Version 65.0.3325.181 (Official Build) (64-bit)
• Operating System and version (desktop or mobile): Windows 10 Version 1709

Expected Behavior

I'm expecting it to be awesome

Current Behavior

It is!

Possible Solution

Ship it!

Steps to Reproduce (for bugs)

1. Ship it!
2. Ship it good!

Context

I was trying to create an issue

Your Environment

• Version used: 1.0.0
• Browser Name and version: Chrome 48
• Operating System and version (desktop or mobile): OS X El Capitan
• Link to your project: https://www.talater.com/open-source-templates/

In one of the path, you can end up with a ISSUE_TEMPLATE.md having 2 Context sections.

Expected Behavior

Each section should have a different name.

Current Behavior

After following the "adventure" I got a md file with 2 Context sections.

Possible Solution

Maybe replace

## Context
<!--- Provide a more detailed introduction to the issue itself, and why you consider it to be a bug -->

by

## Description
<!--- Provide a more detailed introduction to the issue itself, and why you consider it to be a bug -->

Steps to Reproduce

1. Visit https://www.talater.com/open-source-templates/#/page/98
2. Choose the Issues box
3. Choose "Focus on bugs"
4. Choose "My project run in the browser"

Thanks!

1. Open graph tags.
2. Twitter share

Questions:

• Only accept PRs connected to an issue?
• Require tests?
• Do you have a CONTRIBUTING file?

Description

Motivation and Context

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.
• My code follows the code style of this project.

Credits:

• @appium