Expo router starter has wrong colorScheme on device set on light mode about tamagui HOT 7 CLOSED

Just noticed that deleting the lockfile and the node_modules folder, and then reissuing yarn install, make the ThemeProvider work... what a nightmare, I believe yarn 4 is giving inconsistent results for some reason totally unknown to me.

I also tried to compare the “pre” and “post” lock files, but the diff is huge.
react-native-screens went from 6.5.11 to 6.5.20
@react-navigation/native-stack went from 6.9.17 to 6.9.26
@react-navigation/elements went from 1.3.21 to 1.3.30

and the "weird" change is this one:

where expo router uses 6.1.6 but the 6.1.17 was added

from tamagui.

Hi @giacomocerquone, thank you for your feedback and advice! I made a pr with changes, should work now if you want to test it

yes it is, thank you!

from tamagui.

I'm not even sure the problem lies here or in expo router (or react navigation) since it seems like the DarkTheme passed to the ThemeProvider is not applied.

from tamagui.

pushed fix, can you try now?

from tamagui.

pushed fix, can you try now?

Hey there. Thank you, but no, now on both light and dark mode, it appears like this:

Also, here you should not set defaultTheme: https://github.com/tamagui/tamagui/blob/master/starters/expo-router/app/_layout.tsx#L47, but removing it still doesn't solve the problem and most importantly, you shouldn't push stuff like that, it makes difficult for me, or other contributors, to comment or to give feedbacks in general.

What do you say of opening a PR next time?

from tamagui.

Imho your changes are wrong and should be reverted.
You've also added a background="$bg" to the index view which sounds wrong since the background should be actually enforced by react-navigation that is not correctly applying the theme (react-navigation or expo router, one of the two).

I've started an expo project that has slightly different libs version and then added tamagui on top of that and it's working really well for some reason. I could investigate on that but running out of time sadly

from tamagui.

Hi @giacomocerquone, thank you for your feedback and advice! I made a pr with changes, should work now if you want to test it

from tamagui.