Giter VIP home page Giter VIP logo

Comments (5)

kasrak avatar kasrak commented on July 20, 2024 1

Ah, I figured out another temporary fix for anyone running into this with npm. When I add @tamagui/floating as an explicit top-level dependency in my package.json, the popover works as expected. I think multiple copies of @tamagui/floating were being installed previously.

	"dependencies": {
		"@tamagui/config": "1.100.0",
		"@tamagui/floating": "1.100.0",
		"tamagui": "1.100.0"
	},

from tamagui.

kasrak avatar kasrak commented on July 20, 2024

From Popover.tsx

const sheetActive = useSheetBreakpointActive(sheetBreakpoint)

const floatingContext = useFloatingContext({
  open,
  setOpen: handleOpenChange,
  disable: sheetActive,
  hoverable,
  disableFocus: disableFocus,
}) as any

When I run the repro example, sheetActive looks like {current: undefined}, so the value of disable is truthy

from tamagui.

shiroyk avatar shiroyk commented on July 20, 2024

A few days ago, I also encountered this issue. I noticed that there is a package-lock.json file in the project you provided, indicating that you probably used npm install to install the dependencies. A temporary solution is to run rm -rf node_modules && yarn install

from tamagui.

kasrak avatar kasrak commented on July 20, 2024

Interesting, thank you -- that does seem to solve it in the repro. But ideally I'd love to find a way to make it work with npm because migrating our main repo from npm to yarn for this issue doesn't make a ton of sense.

Do you have any theories on why yarn vs npm install might be resulting in different behavior?

from tamagui.

shiroyk avatar shiroyk commented on July 20, 2024

npm resolves dependencies differently than yarn, and this issue might be caused by conflicts between certain dependency versions.

from tamagui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.