tananaev / rootless-logcat Goto Github PK

According to our research, there are misuses about the following AsyncTask class:
( in com.tananaev.logcat. MainActivity)

private ReaderTask readerTask;
//……
private class ReaderTask extends AsyncTask<Void, StatusUpdate, Void> 

The problems is:

1. It is inner class. It holds strong reference to the GUI element of Activity( MainActivity ), which can lead to memory leak when the Activity is destroyed and the AsyncTask did not finish.

I think we can make following changes to fix the misuse problems:

1. I think the GUI-related fields should be wrapped into WeakReference. Take
   private final MainActivity _context as example, it can be changed to private final WeakReference<MainActivity> _context.

how can i find my app process logcat message ,it just show my app process class trace

Is there any chance you could add the option to use root access instead of enabling remote debugging for logging?

I'd love to see your app on F-Droid. If you are OK with this, I'll add it.

Use case: to filter the log for a number of different elements and share a single filtered log with all events in order.

Instead of using regionMatches to detect for a keyword or tag match, could a list of strings, or potentially a regular expression be used instead?

Potentially could also filter the log at the shell:logcat level to reduce the memory requirements:
-e , --regex= Only print lines where the log message matches where is a regular expression.

Use case: to filter the log by application - instead of using a PID Number (Process ID)

Could a PID lookup to Application Identifier (com.google.xxxx) be implemented?

Grep like, include this, exclude that.

To expand on the play store comments:

• the way I use this is to look at logs where it's not easy to attach a proper logcat viewer. For example something gps-related, or wifi/cell network crossing. It is much easier to match what happens in the physical world (e.g. I've stepped outside the wifi range) with what happens in the app if I could look at the logs for the app right when I'm moving around. Certainly I can copy the log and email it to myself, but then I'd have to remember the exact time when something happened to match it with the log later. So filtering by bundle id would be immensely helpful.
• timestamps aren't even shown on the play store screenshots, so I'm sure it's easy to reproduce ;)

It would be really appreciated if a changelog is available to see what changes are new to a version. If someone usages the application via F-Daroid then all they see is an update not what is updated. Maybe use something like keep a changelog.

Would you consider publishing the .apk here at Github, for folks without Playstore? Preferably in the releases/ section (see: Creating Releases in the GitHub Help), which is really easy. If you'd do so, I could automatically pick it up (within 24h or your attaching it there) and offer it via my F-Droid compatible repo, and those folks would get automated updates even.

Suggesting a material dark theme, and the ability to adjust the font size