Giter VIP home page Giter VIP logo

Comments (7)

jeroentrappers avatar jeroentrappers commented on June 27, 2024

This is due to the animation block. When pulling the code from the animation block, the corners are rounded again, but you lose the animation when the size of the badge is changed.

from bbbadgebarbuttonitem.

m3ki avatar m3ki commented on June 27, 2024

Do you know of a way to fix this properly while keeping animation?

from bbbadgebarbuttonitem.

m3ki avatar m3ki commented on June 27, 2024

I was able to fix this issue by changing the this code:

    [UIView animateWithDuration:duration animations:^{
        [self updateBadgeFrame];
    }];

to

self.badge.layer.masksToBounds = YES;
 [UIView animateWithDuration:duration animations:^{
     [self updateBadgeFrame];
 }];

from bbbadgebarbuttonitem.

Broich avatar Broich commented on June 27, 2024

Wondering if this project is still alive enough to accept the pull request that fixes this issue.

from bbbadgebarbuttonitem.

TanguyAladenise avatar TanguyAladenise commented on June 27, 2024

Hi guys,

Sorry for not being reactive on the repo. I have a lot on my plate and did not get the chance to work with it and maintain it.
I wanted to take some time to test the fixes and do some refactoring for a new version.
Anyway I will try to do better next time ;)

from bbbadgebarbuttonitem.

Broich avatar Broich commented on June 27, 2024

Awesome! Great news, thank you!

from bbbadgebarbuttonitem.

gabmarfer avatar gabmarfer commented on June 27, 2024

Please, could you update the pod spec version to match the latest code version?

Thanks in advance!

from bbbadgebarbuttonitem.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.