taniarascia / takenote Goto Github PK

I seriously cannot figure out how to get the x and y position of an element so I can absolutely position the note options containers for each list item with JavaScript.

Add the ability to drag a note into the trash, favorites, or a category.

It is possible to delete "wrong" note.

Steps to repeat:

1. Selected a note to make it active
2. Click the note options of another note
3. Click "Delete note"

Result: The active note gets deleted
Expected result: The note of which the note options where opened should be deleted

Add GitHub authentication.

• Ability to log in with GitHub
• Connect TakeNote with a single gist
• Display all individual notes as .md files within TakeNote Gist.

They should be ctrl+alt not alt+ctrl.

If you make a very long note, it only displays the first thousand or so characters until you click on the editor, then the rest appears.

Right now when pressing the "Save" button the user doesn't really know if the saving was indeed done.
Some feedback would be nice, maybe a discrete message that fades after some time.

Add a badge in the sidebar with counts.

Hello and thanks for your project,

I think it would be a nice touch to have a screenshot of how the note taking app looks and maybe some features explained in the Readme.

I see that drag and drop was added previously, but I cannot get it to work in Chrome, Firefox, or Safari on macOS.

I would expect to be able to drag a note to favorites, trash, or a category, but I can do none of these. I am able to drag a note around, but when I drop it on any of these items it moves back to its original place and doesn't move to the appropriate folder.

• Add a search bar (either above the note list, or general app sidebar list)
• Search through all notes

Settings modal:

• Update theme along with dark mode (zenburn is there for example)
• Vim mode toggle (for vsergeev)
• Display keybindings options (do not allow editing keybindings at this time)
• Various code mirror options toggle

And it better be New Moon.

After activating dark mode, I discovered that on every page reload, it is deactivated.

There should be settings to save the current theme on the browser's storage system.

Thank you : )

Some people might not want the active line highlighted.

It would be nice if we could rename a category, instead of removing it and recreate it

Right now, the app syncs to localStorage every 30 seconds.

In KeyboardShortcuts.tsx, an interval is set.

  useInterval(() => {
    _syncState(notes, categories)
  }, 30000)

This should not be in Keyboard Shortcuts, but more likely App.tsx or SettingsModal.tsx. The settings modal should have an option to toggle sync on and off, and set sync interval.

A sensible default should be set - sync on and set to 30 seconds or something. Bonus points if the sync doesn't go through if the last updated note is within 5 seconds or something - to prevent sync while typing.

Pointed out by @AM-Myrick - new notes will not display a title if the first character is a newline. The whole getNoteTitle function needs to be rewritten to fix this bug and display properly if the first character is header markdown.

On Windows, CTRL + C doesn't copy the text and creates a new Category instead.

Each new TakeNote account should begin with an example note, that explains everything you can do.

• Creating notes
• Creating categories
• Keybindings (ctrl + n for new note, for example)
• Sync

Right now, new button is hidden when trash folder is selected. Instead, just make a new note in “all notes”.

Hi! Had a chance to glance through the code briefly, and wanted to offer up some suggestions:

• First, I'd strongly suggest that you try using our Redux Starter Kit package once you feel like you understand the basics of Redux. It should simplify a lot of the logic and code that you already have here. For example, the entire actions/index.ts file can be removed completely, as can most of constants/index.ts, because RSK's createSlice function automatically generates action creators and action types for you.
• Next, while Redux itself doesn't care about folder structures, our recommendation at this point is to use a "feature folder" approach, or even the "ducks" pattern for putting all logic for a given Redux feature into a single file. See the Redux FAQ entry on folder structures for comparisons, and the RSK usage guide on createSlice for some discussion of using RSK to write "ducks" files.
• Finally, I see that you're using sagas here. Sagas are a great power tool, but the majority of Redux apps don't need them. In your case, it looks like all you're doing is fairly simple data fetching. This can easily be done with Redux "thunks" and async functions. For example, this saga:

function* fetchNotes() {
  try {
    const notes = yield requestNotes()

    yield put(loadNotesSuccess(notes))
  } catch (error) {
    yield put(loadNotesError(error.message))
  }
}

export function* allSagas() {
  yield all([
    takeLatest(Actions.LOAD_NOTES, fetchNotes),
  ])
}

becomes this thunk:

const fetchNotes = () => async dispatch => {
    try {
        const notes = await dispatch(requestNotes());
        dispatch(loadNotesSuccess(notes);
    } catch(error) {
        dispatch(loadNotesError(error.messsage);
    }
}

So, sagas are definitely not necessary here, and thunks should be simpler for this use case.

If you use RSK's configureStore function, it adds the thunk middleware to the store by default.

See the Redux FAQ entry on choosing an async middleware for more info, and the RSK "Advanced" tutorial" shows how to do data fetching with thunks and use it with TS.

One other suggestion: while connect is our main API for interacting with the store from components, we also now have a React-Redux hooks API as well, which may be simpler to work with in terms of lines of code and TS usage. You might want to try those out.

Hopefully these suggestions are useful. Please let me know if you've got any questions I can help with!

Open note menu > Move to category > Remove category > Click! -- the app crashes with a blank screen

Add react-testing-library tests and Jest unit tests.

Will add test cases here as I think of them.

My files aren't persisting in local storage between refreshes. But the very first note I made, is still there. So there's a regression somewhere.

any plans for preview markdown on the editor?

Use temporary category state. If category input is empty and user clicks away, do not submit.

• Add ability to permanently delete note (remove from notes array)
• Add ability to restore deleted note (remove trash property)
• Do not allow making a new note from trash (disable addNote if Folder is TRASH)

@all-contributors please add dave2kb for design,ideas

Scope: contribution from the community.

Description: It would be much helpful for the contributors to have a common and guiding template for creating issue. I know this is kind of egg and chicken problem that this issue is being created to create a proper issue. Anyway, I know it is quite trivial to create a Template for issue from setting interface. Just need someone to do it.

Associated Resources: Although it is trivial to find the relevant document, here is a quick link for it to save searching for it, https://help.github.com/en/articles/creating-issue-templates-for-your-repository

Right now, all notes default to markdown files with markdown highlighting. Perhaps you should be able to select other languages and get the highlighting for that type of file.

My issue with this is I use markdown with frontmatter as the note data right now, and if I changed the file type to something else, it would lose the frontmatter metadata.

Add favorites option to main app sidebar, on the same level as Notes and Trash.

• Add a “favorite” parameter to NoteItem state and interface.
• Show filtered view for favorites

A user landing on the page can be confused right now, believing they can type immediately. However, the app does not begin with any active note, nor does it have an example note.

In the case that no notes exist on initial load, create a new empty note. Do not create a new empty note if they delete all notes - only initial load.

• Properly style app
• Make mobile/tablet responsive

Actual Behavior:

Using ctrl+option+t keyboard shortcut to enable dark mode is not applying it properly:

It appears to work fine when there are no notes selected.
After adding a note -> the 'All Notes' sidebar is in bright color, rest is properly dark.
Overall, the behaviour when having notes, and having no notes selected is different.

Expected Behaviour:

Dark mode is applied correctly, same as using the switch in settings modal:

Specs:

Seen on MacOS 10.14.6, using Chrome 79 and Firefox 70

Additional notes:

Also: using dark mode with keyboard shortcuts is not visible on settings modal -- so maybe this issue is known and that's why it's not been added yet to settings modal keyboard shortcuts section.

Hopefully this issue will help with debugging and tracking this.

If I press "d" then a download is triggered.
If I press "t" then dark mode is toggled, etc.

Shouldn't it only trigger these while holding down ctrl, or some other key?

keyMode stays in default after attempting to toggle Vim mode.

Just leaving notes here on the functionality that should be tested.

Notes

• create a note
• update a note
• send a note to trash
• add a note to favorites
• add a note to category
• permanently delete a note
• restore a deleted note
• empty trash
• search notes
• list proper notes per folder or category in order

Categories

• create a category
• delete a category

Settings/Sync

• sync a note

Figure out why global keybindings can't access local React hook state.

It is not a bug, just a suggestion. When using Vim mode, It would be interesting, if the cursor change the color (or shape) so we know if we are in the edit mode for example.

Issue and Steps to Reproduce

1. Settings
2. Enable Vim Mode
3. Create a new note
4. Put insert mode into the editor (press i)
5. Write some text
6. With arrow keys of your keyboards go left and right

Attachment

Expected

The cursor move with your arrow keys movements

Actual

The cursor is fixed at the last position of it.

1. Drag note to editor
2. Note uuid text appears in the editor

@taniarascia's preference is to sort and group imports as follows:

1. Libraries
2. Local imports (absolute, not relative)
3. CSS/side-effect imports

With each group alphabetized by from, named imports sorted within their lines, and spaces between the groups.

Right now, there are multiple rule/plugin/preset options for linting imports, none of them quite does the trick right now, they all conflict with each other, and none of them individually is really a desired compromise. However, the hopefully-upcoming merging of import-js/eslint-plugin-import#1360 should make import/order a perfect candidate.

See also:

• react-dnd/react-dnd#219
• react-dnd/react-dnd#221