target / emoji_manager Goto Github PK

When a user proposes an emoji but dosn't leave a comment (because hey, some emoji speak for themselves!) Emoji Manager renders that comment as the literal word "null"

The setup-gradle action has a typo in the config, an accidental double @ appeared, breaking the workflows.

The custom "steps from apps" for WFB is moving to a premium model with additional costs. In an effort to keep Emoji Manager accessible to teams that don't wish to pay for custom steps.

This reimplementation should:

• Provide a GUI Modal for proposing aliases
• Provide a GUI Modal for proposing removals
• Provide the user feedback on errors/mistakes

Today if a new emoji proposal will replace an existing emoji, the proposal indicates that. However, if an alias proposal would replace an existing emoji or existing alias, there is no notice to the user about that. We should add better wording.

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

Small emoji image previews look less blurry, more similar to actual emoji that gets rendered in Slack. Right now they look significantly more blurry than they end up looking in slack, causing people to downvote proposals more often than they would if they could see a better preview. See attached screenshot as an example.

I did some digging. Looks like the small image preview (which is the most blurry), is generated here: https://github.com/target/emoji_manager/blob/main/src/main/kotlin/com/target/slack/ImageHelp.kt#L154

It is using the default scaling algorithm from the scrimage library, which is Bicubic. Maybe there's a better scaling algorithm for the small size of preview images that are generated?
https://sksamuel.github.io/scrimage/scale/

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

When uploading an emoji, if Slack rejects the emoji or it fails in some other way, alert the admins in the same channel the 🔸 notifications.

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.