tarsius / orglink Goto Github PK

I'm new to this mode. I quite like it, but I get several parts of elisp code linkified that are not links. For example:

(put-alist 'org-bbdb-anniversary-format-alist "obit"
       (lambda (name years suffix)
     (concat "[[bbdb:" name "][" name "'s "
         (number-to-string years)
         suffix " obit]]")))

or

(looking-back "^[[:space:]]*")

This is a bit annoying. Is it useful at all to search for links in code (i.e. outside of comments?). It is quite easy to test whether a certain POS is inside a comment by checking

(nth 4 (syntax-ppss pos))

After running `org-activate-*-links you could run through the buffer a second time, looking for property org-link, and remove those org-link propertizations that are outside of comments.

Hi,

since org is one of very few ways to get hyperlinks in any arbitrary buffer (linkd.el is another, but not so widespread), and org is part of Emacs, this package IMHO should consequently become a part of org. I think many Emacs users unsuccessfully search for the feature this package offers in vanilla Emacs/org. Just my personal opinion,of course.

Hello Jonas,

with emacs -q,

• if you type M-x ielm RET followed by M-x orglink-mode RET, it is not possible to type anything into the prompt;
• and the same holds for M-x eshell RET.
• It seems likely that other comint-derived major-modes are affected too.

Instead of inserting the input, this is echoed: funcall-interactively: Text is read-only.

Thankfully,
Mekeor

I have Emacs 28.2 and this doesn't seem to be installed, even with the compat dependency which I assume is a polyfill for the future API.

I can't find it orglink.el, but in my experience when I activated orglink-mode in a LUI-derived major-mode buffer it makes it readonly. Do you know what this might be about?

Hi,

when looking at `orglink-heading-link-search' and it's hardcoded ";;;+", it seems to me that orglink is currently limited to lisp modes. I don't see a necessity for such a limitation - do you plan to get rid of it?

When attempting to M-x global-orglink-mode this is error that I get:

turn-on-orglink-mode-if-desired: Symbol’s value as variable is void: org-link-descriptive

Using Emacs from git:

GNU Emacs 27.0.50 (build 5, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2019-09-07

Would it be possible to work inside org-babel?;)

When you have (setq orglink-match-anywhere t) enabled and try to comment a line beginning with an org-link, the inside of the link description ends up commented instead of the link itself.

For example say I have a scratch buffer like this:

;; This buffer is for text that is not saved, and for Lisp evaluation.
;; To create a file, visit it with SPC f f and enter text in its buffer.

[[file:foo.html][blarg]]

On the last line if I run M-: (comment-region (line-beginning-position) (line-end-position)) I end up with

;; This buffer is for text that is not saved, and for Lisp evaluation.
;; To create a file, visit it with SPC f f and enter text in its buffer.

[[file:foo.html][;; blarg]]

Is there a way to fix this?

I've found several other functions are also failing, and can't really work out how I'm expected to hook orglink mode since if I hook it into text-mode it gets called in org-mode and then throws an error.

Debugger entered--Lisp error: (error "Orglink Mode doesn’t make sense in Org Mode")
  signal(error ("Orglink Mode doesn’t make sense in Org Mode"))
  error("Orglink Mode doesn't make sense in Org Mode")
  orglink-mode(1)
  turn-on-orglink-mode-if-desired()
  global-orglink-mode-enable-in-buffers()
  run-hooks(after-change-major-mode-hook)
  run-mode-hooks(org-mode-hook)
  org-mode()
  org-get-local-variables()
  org-run-like-in-org-mode(org-insert-link)
  org-insert-link-global()
  funcall-interactively(org-insert-link-global)
  call-interactively(org-insert-link-global nil nil)
  command-execute(org-insert-link-global)

Note: My value of orglink-activate-in-modes is '(hledger-mode text-mode prog-mode conf-mode).