tatango / ember-social Goto Github PK

Hey guys, thanks for the nice plugin.

Is there any plan to add the shared event on facebook-share?

Can we add the event on this line?

https://github.com/plyfe/ember-social/blob/38cea5b8bd1a78a217f2074dac8a4aed564a148a/addon/components/facebook-share.js#L60

I know facebook send the same response even if the dialog was closed, but for now I need this in a situation I have and maybe others can have the same case. Also if the user is logged-in on your app facebook then confirm the post with a post_id on the response.

If it's ok and a PR helps, lemme know!!

Ember 3.x
DEPRECATION: ember-cli-babel 5.x has been deprecated. Please upgrade to at least ember-cli-babel 6.6

I would like to share using facebook app.Can I share on native facebook app.Now I use the following code {{facebook-share url='https://www.facebook.com/myanmarghoststory.mm/videos/1715921075218256/'}} in emberjs. And I create the app using cordova.I shared on facebook by web view. Not want to web view.I want to native facebook app on share.How to create?
Pls help me.

Some deprecation warnings are thrown in regards to services when using the addon with Ember 2.7.0.

I am getting many errors related with the Content Security Policy.
I knew I could set the contentSecurityPolicy in the config/environment.js but I couldn't figure out exact settings.
Any recommendations?

Not sure what the issue is here. I believe @chrislopresto has investigated a bit.

If the SDK is loaded by an external source, e.g. torii, the addon quietly hangs waiting for window.fbAsyncInit to run. The SDK skips running the method if window.fbAsyncInit.hasRun is set to true, so the promise never resolves.

A similar issue has been raised over at torii, but their bug is slightly different.

We can't just return the loaded SDK, because it may have been loaded with different settings, for example without fbxml: true. We also can't re-init with our own settings for similar reasons and because that could lead to even more subtle breakage.

I propose the following solutions:

1. It would be great to at least warn developers if Facebook is already loaded with an assertion.

load: function() {
  if (facebookScriptPromise) { return facebookScriptPromise; }

  Ember.assert('The Facebook SDK has already been loaded...',  window.FB);`

  // load the SDK...
}

If you're already using the SDK somewhere else in your app, it should be your responsibility to load it once with all the correct options you require.

2. We could provide guidance in the README and/or the assertion message to suggest developers to extend the service and override the load method. I small hint goes a long way.

import Ember from 'ember';
import FacebookApiClientService from 'ember-social/services/facebook-api-client';

export default FacebookApiClientService.extend({
  // If you're providing your own service, provide access to a promise which resolves to FB
  facebookSDK: Ember.inject.service('facebook-sdk'),

  load: function() {
    var facebookSDK = this.get('facebookSDK.FB');
    if (facebookSDK) { return facebookSDK; }

    return this._super(...arguments);
  }
});

3. Lastly, there's the option of integrating a way to 'pass-your-own-sdk' as an argument, but I think that's overkill. Option 2 seems more than enough.

I've patched both ember-social and torii in this way in my app by loading and initializing the SDK in a service on the application route.

Let me know what you like or don't like. Ready to provide a patch immediately.

Can't seem to get this to work:

{{twitter-share count='horizontal' text=tweetURL}}
{{tweetURL}}

Any ideas? Is this a supported feature at all?

I'm trying to use the facebook-share component and when I click it I get a pop up window that says "The parameter app_id is required". How do I tell ember-social what my app_id is?

Hi there,

Is there any way to pass a variable as the tweet-id argument? For example...

The following code snippets do not work for me; in both cases where myTweetId is a number and the case where it is a string.

{{twitter-card tweet-id='myTweetId'}}
{{twitter-card tweet-id=myTweetId}}

The code shown in the documentation {{twitter-card tweet-id='463440424141459456'}} works for me.
Am I missing something here?

Thank you!

Hi guys,

I´m getting an error when I trying to share on Facebook.

sdk.js:33 Uncaught SyntaxError: Unexpected identifier
I recently double check and the same error happens running the Dummy App on the repo.

Thanks!

(injected) Tracking Service which implements shared and clicked does not get the right payload when called for email or twitter.

Will try to get a PR when I get a chance

hi

Does it fit the whole project?
I would do that but I am not that ember literate..

thankyou

Hi, on https://www.npmjs.com/package/ember-social latest version is missing

The count display for twitter shares is:

{{twitter-share count='horizontal'}}

With vertical as the other option, displaying the count on the right and top, respectively.

However, for linkedin shares, the API is:

{{linkedin-share count='top'}}

With right as the other option.

It would make more sense for the Twitter-Share component to align with the Linkedin-Share API.

ember serve the dummy app. Facepile doesn't show:

• without parameters - nothing shows
• custom URL - facebook icon and likes shown. No faces.
• with theme - only a black bar shows for 'dark' theme.

{{#facebook-share tagName="a" fb-layout='button' url=this.shareUrl caption="caption" description="description" picture="[redacted]/1450474936965/003.jpg"}}
    Share on Facebook
{{/facebook-share}}

Hello,

Additional properties such as caption, description & picture don't seem to be supported. Am I missing something?