taviso / lotusdrv Goto Github PK

If you try to display a graph or press F10, the driver will currently crash.

This should be an easy fix, just some missing API stubs.

Running 1-2-3 release 3.4 with this driver on a terminal with 64 or more lines causes the bottom of the display to mirror the top of the display:

I’m not sure if this is a driver bug, a fundamental limitation of 1-2-3’s graphics API, or a dosemu2 bug, but it seems worth documenting in any case. (Beyond this issue, the driver seems to work great with release 3.4. Thanks for making it a reality!)

I’m using dosemu2-2.0pre8-20210718-3057-gd488fe7b9 (revision 6756).

stty rows $((LINES > 63 ? 63 : LINES)) (or tmux setw force-height 63, if you’re in tmux) is a good workaround.

I haven't tried yet, but does it work on real hardware and if yes, which VGA chips or APIs would be supported?

I think the driver doesn't reinitialize properly, if you try to use /Tools DOS, 123 crashes when you exit the DOS shell. This includes if you have any macros that run external commands.

I think I know the problem, but will need to do some debugging.

Note to self: I think the driver is Terminated() and then Reinitialized() when you exit DOS, so I'm not cleaning up properly.

I think there's a minor visual glitch, the last row does not seem to be colored correctly.

I don't really know what's causing that.

This is probably not possible / a silly idea.. but I wonder if it would be possible to support terminal window resizing ?

I don't know if you could query the terminal size directly, or if you'd have to add something to DOSEMU so it would cooperate, when it received WINCH, putting that data somewhere you could read it ?

If you enter POINT mode (F4) and then move around a big sheet with the arrow keys like crazy, there are some visual glitches.

They seem mostly harmless, but the original driver works so it must be a bug in my code somewhere.