Giter VIP home page Giter VIP logo

mywarp's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

mywarp's Issues

Permissions groups with inheritance

I have a solution that will allow the use of groups as well as players. I have done it this way to improve inheritance of groups.

when using the Permissions plugin:
Using PermissionHandler.inGroup(player, 'Default') will not return true for a player in "Admins" even if Admins is inherited from Default. (please correct me if I'm wrong, but my experience is that it doesn't.)
By adding a generic permission to a group, "group.<group_name>", it is possible to check for that permission with inheritance. Within MyWarp is is possible to invite a permissions group, or to give a warp to a group. However, since playerCanWarp and playerCanModify only check for a player by name, it will not map over and allow the action.

I propose the following changes as a fix. I have tested this on my own server and it seems to work well.

To Warp.java these edits:

public boolean playerCanWarp(Player player) {
    if (creator.equals(player.getName()))
        return true;
    if (permissions.contains(player.getName()))
        return true;
    //amkeyte
    if (WarpPermissions.isGroupMember(player, permissions))
        return true;
    if (WarpPermissions.isAdmin(player) && WarpSettings.adminPrivateWarps)
        return true;

    return publicAll;
}


public boolean playerCanModify(Player player) {
    if (creator.equals(player.getName()))
        return true;
    //amkeyte
    //give the warp to a group to allow them to modify it.
    if (WarpPermissions.isGroupMember(player, creator))
        return true;
    if (WarpPermissions.isAdmin(player))
        return true;
    return false;
}

to WarpPermissions.java add these functions:

/**
 * amkeyte
 *
 * checks if the player is a member of a group using the Permissions plugin.
 *
 * The player must be a member of a group that has been given the permission:
 *              group.<Group Name>
 *
 *  This method of checking for group allows the permissions plugin to assign by inheritance.
 *
 * @param player
 * @param permissions
 * @return
 */
public static boolean isGroupMember(Player player, String groupName) {
    String groupPermission = "group." + groupName;
    if (permission(player, groupPermission)) {
        return true;
    }


    return false;
}
/**
 * amkeyte
 * Overloaded from above.
 * 
 * checks if the player is a member of a group in the list.
 * Iterates each item in the list and checks if the player is in the group.
 * players may invite a group to their warp just like they would a player.
 *
 * called by Warp.playerCanModify
 * 
 * @param player
 * @param permissions
 * @return
 */
public static boolean isGroupMember(Player player, ArrayList<String> permissions) {
    for (Iterator iter = permissions.iterator(); iter.hasNext();) {
        if (isGroupMember(player, (String) iter.next())) {
            return true;
        }
    }

    return false;
}

You might decide to go with a more specific permission property, (mywarp.warp.group.<group_name>) but I like the more generic one, since this technique could be helpful in other plugins as well.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.