tbolier / php-rethink-ql Goto Github PK

Issue summary

The current ReQL document manipulation commands implementation is currently missing in the driver.
https://www.rethinkdb.com/api/java/

Selecting data

• Joins
• innerJoin
• outerJoin
• eqJoin

The following sections can be removed only, whenever they are not applicable or you have a simple question.

Actual Behavior

• Not implemented

Expected Behavior

• A working implementation including unit / integration test.

Issue summary

The current ReQL document manipulation commands implementation is currently missing in the driver.
https://www.rethinkdb.com/api/java/#between

Selecting data

• between

The following sections can be removed only, whenever they are not applicable or you have a simple question.

Actual Behavior

• Not implemented

Expected Behavior

• A working implementation including unit / integration test.

Issue summary

The current ReQL command implementation is currently missing in the driver.
https://www.rethinkdb.com/api/java/#sync

Writing data

• sync

The following sections can be removed only, whenever they are not applicable or you have a simple question.

Actual Behavior

• Not implemented

Expected Behavior

• A working implementation including unit / integration test.

Issue summary

We would like to listen to the change feeds via PHP.

Docs: https://rethinkdb.com/api/javascript/changes/

Issue checklist

• Implement changes
• Implement changes unit tests
• Add changes documentation
• Implement changes options
• Implement changes options unit tests

Actual Behavior

There is no changes listener in the driver.

Expected Behavior

Given I am listening with changes
When new data is crudding
Then I should see a stream of change messages

Specifications

• PHP Version: 7.x
• RethinkDB Version: 2.3+

Issue summary

The current ReQL document manipulation commands implementation is currently missing in the driver.
https://www.rethinkdb.com/api/java/#zip

Selecting data

• zip

The following sections can be removed only, whenever they are not applicable or you have a simple question.

Actual Behavior

• Not implemented

Expected Behavior

• A working implementation including unit / integration test.

Currently highest version possible for PHP 8 is 1.2.1. Please adjust composer requirements to make this project installable via composer for PHP8

Thank you

Issue summary

The current ReQL document manipulation commands implementation is currently missing in the driver.
https://www.rethinkdb.com/api/java/

Selecting data

• reduce
• fold
• distinct
• contains

The following sections can be removed only, whenever they are not applicable or you have a simple question.

Actual Behavior

• Not implemented

Expected Behavior

• A working implementation including unit / integration test.

Issue summary

The current ReQL document manipulation commands implementation is currently missing in the driver.
https://www.rethinkdb.com/api/java/

Document manipulation

• map
• withFields
• concatMap
• slice
• nth
• offsetsOf
• union
• sample

The following sections can be removed only, whenever they are not applicable or you have a simple question.

Actual Behavior

• Not implemented

Expected Behavior

• A working implementation including unit / integration test.

Currently we only have integration tests, next to integration tests, we also need to bring the unit test code coverage above 90%. We do not have any unit test yet in the project.

Each unit should have a test, all other objects should be mocked within the test.

Hey tbolier! I don't know if your driver already supports fully the 2.3 version, but we've forked RethinkDB to release a 2.4 version and all drivers will have separate repositories under our organization, discussion here: https://spectrum.chat/rebirthdb

So I'm inviting you to join us, there you can have more visibility for your project, what do you think?

Hi !

Do you have a chat or something to communicate with you ? I miss some function like now, hasFields, distinct, map, contains, without, merge, add, sub, not, ISO8601.
I would like to implement them, but I'm stuck to implement among others now, add, and not.
I don't have your logic and the way of thinking of this lib.

Thanks

Issue summary

The current ReQL document manipulation commands implementation is currently missing in the driver.
https://www.rethinkdb.com/api/java/

String manipulation

• le
• ge
• not

The following sections can be removed only, whenever they are not applicable or you have a simple question.

Actual Behavior

• Not implemented

Expected Behavior

• A working implementation including unit / integration test.

Issue summary

The current ReQL command implementation is currently missing in the driver.
https://www.rethinkdb.com/api/java/#index_wait

Manipulating tables

• indexWait

The following sections can be removed only, whenever they are not applicable or you have a simple question.

Actual Behavior

• Not implemented

Expected Behavior

• A working implementation including unit / integration test.

Issue summary

The current ReQL dates and times commands implementation is currently missing in the driver.

https://www.rethinkdb.com/api/java/

Dates and times

• now
• time
• epochTime
• ISO8601
• inTimezone
• timezone
• during
• date
• timeOfDay
• year
• month
• day
• dayOfWeek
• dayOfYear
• hours
• minutes
• seconds
• toISO8601
• toEpochTime

The following sections can be removed only, whenever they are not applicable or you have a simple question.

Actual Behavior

• Not implemented

Expected Behavior

• A working implementation including unit / integration test.

To test I'm now using this code:

$r = new Rethink($registry->getConnection('default'));
$r->connection()->connect();
$r->db()
  ->tableCreate('test')
  ->run();

I'm getting a Runtime Error:

PHP Fatal error:  Uncaught TBolier\RethinkQL\Connection\ConnectionException: Runtime error: U, jsonQuery: [1,[60,[[1,"test"]]],{"db":[14,["vagrant"]]}] in/code/vendor/tbolier/php-rethink-ql/src/Connection/Connection.php:372
Stack trace:
#0 /code/vendor/tbolier/php-rethink-ql/src/Connection/Connection.php(334): TBolier\RethinkQL\Connection\Connection->validateResponse(Object(TBolier\RethinkQL\Response\Response), 820726866, 820726866, Object(TBolier\RethinkQL\Message\Message))
#1 /code/vendor/tbolier/php-rethink-ql/src/Connection/Connection.php(169): TBolier\RethinkQL\Connection\Connection->receiveResponse(820726866, Object(TBolier\RethinkQL\Message\Message))
#2 /code/vendor/tbolier/php-rethink-ql/src/Query/AbstractQuery.php(32): TBolier\RethinkQL\Connection\Connection->run(Object(TBolier\RethinkQL\Message\Message))
#3 /code/bin/OrderBook.php(28): TBolier\RethinkQL\Query\AbstractQuery->run()
#4 {main}

Next TBolier\RethinkQL\Connection\ConnectionException: Runtime error: U, jsonQuery: [1,[60,[[1,"test"]]],{"db":[14,["vagrant"]] in /code/vendor/tbolier/php-rethink-ql/src/Connection/Connection.php on line 181

This is because I did not grant the permissions to the user yet. Might need a different error message.

Originally posted by @mpjraaij in #76 (comment)

Issue summary

The current ReQL document manipulation commands implementation is currently missing in the driver.
https://www.rethinkdb.com/api/java/

Document manipulation

• pluck
• without
• merge
• append
• prepend
• difference
• setInsert
• setUnion
• setIntersection
• setDifference
• () (bracket)
• getField
• hasFields
• insertAt
• spliceAt
• deleteAt
• changeAt
• keys
• values
• literal
• object

The following sections can be removed only, whenever they are not applicable or you have a simple question.

Actual Behavior

• Not implemented

Expected Behavior

• A working implementation including unit / integration test.

Issue summary

The current ReQL command implementation is currently missing in the driver.
https://www.rethinkdb.com/api/java/#index_status

Manipulating tables

• indexStatus

The following sections can be removed only, whenever they are not applicable or you have a simple question.

Actual Behavior

• Not implemented

Expected Behavior

• A working implementation including unit / integration test.

Currently the integration tests are failing in Scrutinizer, because we do not install and setup RethinkDB in the Scrutinizer container. We should configure .scrutinizer.yml with all the necessary requirements to achieve this.

The goal is to have all the integration and unit tests run in Scrutinizer.

Issue summary

Each function in the RethinkDB API (ReQL commands) has a set of commands in the return type interface that can be called (chained / fluent interface).

We need to improve the simplicity of the ReQL query command interface segregation. Currently the interface inheritance is really confusing for current and new developers and might violate the interface segregation SOLID principle in near future.

It is easy to make a mistake at the moment by using the wrong interface as a return type of a ReQL command. Favourable each function will return it's own interface with it's own set of (submodules) functions.

For more information about interface segregation, see:
https://www.oodesign.com/interface-segregation-principle.html

Issue checklist

• Propose interface segregation
• Implement new interfaces

The following sections can be removed only, whenever they are not applicable or you have a simple question.

Actual Behavior

What is it doing now?

• We have too much confusing interfaces.
• New API functions might not support all methods in our current query interfaces. Causing polluted interfaces and violating the interface segregation SOLID principle.

Expected Behavior

• A new ReQL command should be easy to implement.
• Current and new ReQL commands should favourable have their own segregated interface.

Hey, i just wanted to know how i include this in my project I never had to use "use" / namespaces.
I am only getting errormessages like :
Fatal error: Uncaught Error: Class 'TBolier\RethinkQL\Registry' not found in

Hope you dont mind explaining it to to me.

Issue summary

Currently tests don't passed in PHP 7.2 for RowTests.php. PHP 7.3 is now in beta so we must include it too.

If Scrutinizer don't provide the feature, we might consider taking the tests under Travis CI.

Issue checklist

• Add PHP 7.2 tests
• Add PHP 7.3 tests

Hi there,

I'm testing my code on vagrant instances. Now I have Rethink running on one vm, and my code on another vm.

The db is up and running and I can access it via my browser. However inside of the code nothing happens when I run:

$connections = [
    'default' => new Options([
        'hostname' => '<internal ip>',
        'port' => 28015,
        'dbname' => 'vagrant',
        'user' => '...',
        'password' => '...'
    ]),
];
$registry = new Registry($connections);

$r = new Rethink($registry->getConnection('default'));
$r->table('trades')
  ->insert([
      [
          'documentId' => 1,
          'title' => 'Test document',
          'description' => 'My first document.'  
      ],    
  ])
  ->run();

The table exists, the stream is created and connected in socket, however I still get the following:

PHP Fatal error:  Uncaught Error: Call to a member function write() on null in /code/vendor/tbolier/php-rethink-ql/src/Connection/Connection.php:257
Stack trace:
#0 /code/vendor/tbolier/php-rethink-ql/src/Connection/Connection.php(163): TBolier\RethinkQL\Connection\Connection->writeQuery(588962815, Object(TBolier\RethinkQL\Message\Message))
#1 /code/vendor/tbolier/php-rethink-ql/src/Query/AbstractQuery.php(32): TBolier\RethinkQL\Connection\Connection->run(Object(TBolier\RethinkQL\Message\Message))
#2 /code/bin/OrderBook.php(33): TBolier\RethinkQL\Query\AbstractQuery->run()
#3 {main}
  thrown in /code/vendor/tbolier/php-rethink-ql/src/Connection/Connection.php on line 257

Hello,
Are there any approximate plans of 2.0 release?

Desperately waiting for php library with changes function :)