tbotnz / ios-show-run-ttp Goto Github PK

The present template only supports 'service-policy input {{}}'. Proposing to implement 'service-policy output {{}}'

service-policy input {{ input_policy }}
service-policy output {{ output_policy }}

This applies to all types of L3 interfaces

I have already implemented this. Can submit a PR if needed.

Likely due to inconsistencies between Cisco IOS' representation between Switching platforms and routing platforms.

This issue is causing the parser to not fully capture or records configs. Can be fixed by refactoring

encapsulation dot1q {{ dot1q }} to encapsulation dot1Q {{ dot1q }} in line 25

Parse all secondary IP addresses found under interface configs into a list and change IP address notation to cidr instead of ip address mask subnet. This can be implemented by introducing a macro to the interfaces group and using the inbuilt to_cidr method to convert the masks.

Use-case:

1. Makes it easier to create a IPNetwork object from the netaddr library
2. Easier to represent when comparing IPs with a SoT (e.g Netbox)
3. Fully account for IP information in the configs

def parse_ip(data):
	if data.get('primary_ip') and data.get('primary_mask'):
		data['primary_ip'] = data['primary_ip'] + '/' + str(data['primary_mask'])
		data.pop('primary_mask')
	if data.get('secondary_ips') and data.get('secondary_masks'):
		data['secondary_ips'] = [f"{ip}/{mask}" for ip, mask in zip(data['secondary_ips'], data['secondary_masks'])]
		data.pop('secondary_masks')
</macro>

I can submit a PR for this also.