Giter VIP home page Giter VIP logo

Comments (4)

wolframkriesing avatar wolframkriesing commented on July 20, 2024

its the same thing as this, issue, right?
https://twitter.com/mkuehnel/status/769661864464748544
any suggestions to fix it?

from katas.

csakai avatar csakai commented on July 20, 2024

These are not quite the same issue, as one requires an array-like (Reflect.apply), and the other requires an object (Reflect.defineProperty), but the issues are rooted in the same general place - The third param cannot be omitted when demonstrating how the functions work.

A potential solution is to amend your approach to teaching the user how these functions work. Instead of introducing each param separately, each param must be included in each function call.

For example, there can't be any tests where the third param is undefined (Unless you want to indicate that the function will throw if the third param is not an object).

The test 'returns false -> when no property name is given (since no property has been added)' is not valid since the function will throw if you don't give an object as the third param. However, if you do provide an object as the third param, but the second param is "" (empty string), it will still not return false, because the property will be defined on the key "" (empty string) of the given object.

from katas.

KingWarin avatar KingWarin commented on July 20, 2024

@wolframkriesing our twitter conversation is related to issue no. 31 (as stated on top of this site by @csakai )

Possible solution if you want to keep the one param per test approach could be a wrapper for the functions where the params are optional, but I'm not sure if that might cause more confusion instead of being a real help.
As Chris said, the problems root is the same, so this approach is applicable on both issues.

from katas.

wolframkriesing avatar wolframkriesing commented on July 20, 2024

i believe I fixed it in #44 correct?
If not please reopen this issue. thx

from katas.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.