Comments (4)
its the same thing as this, issue, right?
https://twitter.com/mkuehnel/status/769661864464748544
any suggestions to fix it?
from katas.
These are not quite the same issue, as one requires an array-like (Reflect.apply
), and the other requires an object (Reflect.defineProperty
), but the issues are rooted in the same general place - The third param cannot be omitted when demonstrating how the functions work.
A potential solution is to amend your approach to teaching the user how these functions work. Instead of introducing each param separately, each param must be included in each function call.
For example, there can't be any tests where the third param is undefined (Unless you want to indicate that the function will throw if the third param is not an object).
The test 'returns false -> when no property name is given (since no property has been added)' is not valid since the function will throw if you don't give an object as the third param. However, if you do provide an object as the third param, but the second param is "" (empty string)
, it will still not return false, because the property will be defined on the key "" (empty string)
of the given object.
from katas.
@wolframkriesing our twitter conversation is related to issue no. 31 (as stated on top of this site by @csakai )
Possible solution if you want to keep the one param per test approach could be a wrapper for the functions where the params are optional, but I'm not sure if that might cause more confusion instead of being a real help.
As Chris said, the problems root is the same, so this approach is applicable on both issues.
from katas.
i believe I fixed it in #44 correct?
If not please reopen this issue. thx
from katas.
Related Issues (19)
- Kata 34: Symbol HOT 1
- xdomain vendoring HOT 1
- Shorter version of kata 51 "generator:yield" test case #2 HOT 8
- Rest in destructuring HOT 11
- Renaming in destructuring HOT 3
- Misprint in the test HOT 1
- Incorrect values in arrows kata HOT 3
- Solution for Kata 40 freezes the browser tab HOT 1
- Kata 76 - Promise Creation - doesn't wrok in TDDbin HOT 5
- Object.is
- Kata 28 - TDDbin add indentation to super.constructor HOT 2
- Is it OK to move CHANGELOG.md into separate issues? HOT 2
- Two tests in Promises already green when starting
- Build issue HOT 2
- Kata "Destructuring":"rename":"rename object key" is green right away HOT 2
- Question about what to fix in parseInt HOT 3
- template repository to fork and learn HOT 8
- `class extends null` is broken by ECMAScript HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from katas.