Comments (2)
hi @jizusun sorry for answering so late, I understand the "need" and usefulness of using issues on github or even a project, I just miss their integration into the workflow, that's why i started using the CHANGELOG (I described the process and whys here). I understand that this is different to how people are used to stuff working on GH. Maybe some kinda automatic issue creation would be cool :) ... I also work offline a lot, and there I can record progress in a CHANGELOG.
Sorry if that is not a satisfying answer :(.
And a lot of thanks for your love for this project.
from katas.
I'm not sure whether I'm supposed to pull this up again, but I decided to do it since the issue is Open.
I'm finding it difficult to understand the thinking behind those single-line changelog / to-do list items.
On the other hand, I understand the need to be able to work offline; so, here's my proposal - have a description for each todo item ( Definition of Done in 2 sentences or less ) in the changelog file itself. I like the idea of 'automated issue creation', but I don't think a single line would do any good if they were converted to issues either. So having a description would help in converting to GitHub issues as well. Not having a description / definition of done would raise the barrier to entry for new contributors.
I'm currently eyeing at the Todos, Ideas, etc list. I think they can be completed with minimal to no effort. I don't get why they're in the file even. Hence, I think there's more to them than what I think.
I'm going to describe how I understood it. If there's more, please clarify ( and that also would be the case to have a description of the task somewhere, if not in the changelog file )
- Deploy
<kataname>.spec.js
files too (the passing tests).
copy all of the files under thekatas
directory into a newspec
directory, rename the files to have thespec.js
filename extension, remove all the 'katafication' comment lines.
additionally, change all the files in thekatas
to the katafied tests - Verify that all katafied tests fail (the katafication does really create failing tests).
This is already complete in my humble opinion. I've run the whole suite ( from thegh-pages
branch ) locally and have verified that they all fail. There were someSyntaxError
fixes that are fixable ( probably task 5 - Test if katafication results in invalid JS code ) - Remove lines which only have
////
and nothing beyond (I have not seen a case where I would not remove that line).
I don't understand this one. The katafication comment line means that the next line in the file should be removed. If that indicator wasn't there, then the katafied test would pass too because the next line ( the actual solution ) was not removed. And there are many tests which start with an empty line in which the user has to fill in the whole line. Of course, we could put up some dummy lines to make it not only////
and nothing beyond. - Fix vulnerabilities that GH shows.
I think GitHub can do that automatically with Dependabot. It can at least open PRs and we just need to merge them. I guess having a good CI system in place could tackle this issue. - Test if katafication results in invalid JS code
I already commented on this one. If it means that the tests don't result inSyntaxError
s, then I guess I've caught most of them in the one commit that I linked above. - Test if every test has the katafy part in it
I think I can just put a PR marking this task as complete because I've verified it myself. Other than TODO tests ( or tests that simply pass because they have no code inside ), all the other tests now have the katafy part; but I need to be sure whether this is what was meant by the task at all.
from katas.
Related Issues (19)
- Kata 34: Symbol HOT 1
- xdomain vendoring HOT 1
- Shorter version of kata 51 "generator:yield" test case #2 HOT 8
- Rest in destructuring HOT 11
- Renaming in destructuring HOT 3
- Misprint in the test HOT 1
- Incorrect values in arrows kata HOT 3
- ES6 Kata 69 "Reflect - defineProperty" kata needs updating HOT 4
- Solution for Kata 40 freezes the browser tab HOT 1
- Kata 76 - Promise Creation - doesn't wrok in TDDbin HOT 5
- Object.is
- Kata 28 - TDDbin add indentation to super.constructor HOT 2
- Two tests in Promises already green when starting
- Build issue HOT 2
- Kata "Destructuring":"rename":"rename object key" is green right away HOT 2
- Question about what to fix in parseInt HOT 3
- template repository to fork and learn HOT 8
- `class extends null` is broken by ECMAScript HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from katas.