teabyte / nakhlahjs Goto Github PK

Tracking issue for:

• https://github.com/TeaByte/NakhlahJS/security/code-scanning/6

With the development and expansion of the project
The process of testing and ensuring the integrity of each update will become difficult

Deno tests + GitHub actions would be helpful for us and project contributors

remove anything was for track progress using localstorage

Make it PWA ready

It will benefit many learners

We're proposing to migrate our current web analytics framework to PostHog, a modern open-source platform offering advanced features and flexibility.

• Evaluate PostHog Free Version
• Move to Self-Hosting PostHog if we like it

الاختبار في هذا الدرس يحتوى على عوامل مركبه من الدرس التالي. يجب تغير الاختبار حتى يناسب سياق الدرس:

• https://nakhlahjs.site/numbers/intro

الاختبار في هذا الدرس من الافضل ان يكون يكون انشاء سلسله تحوي على عاومل تخطي مثل "\ حتى يخرج المتلقي بفائده اكبر:

• https://nakhlahjs.site/strings/intro

الاختبار هذا لا يمثل الدرس ابدا:

• https://nakhlahjs.site/strings/understand-immutability

سيتم مراجعه الدروس بشكل دوري يرجى عدم قفل الissue

In group route

https://nakhlahjs.site/group/if-statements

When clicking to a URL the URL changes but nothing happened
Probably client-side Partial issue

Tracking issue for:

• https://github.com/TeaByte/NakhlahJS/security/code-scanning/7

في درس التعليقات

https://nakhlahjs.site/comments

زر الرجوع يرجعك الى نفس الدرس وليس الدرس السابق

https://github.com/TeaByte/NakhlahJS/blob/main/utils/course.ts#L143

Tracking issue for:

• https://github.com/TeaByte/NakhlahJS/security/code-scanning/4

phone and small screens users need some adjustments

Tracking issue for:

• https://github.com/TeaByte/NakhlahJS/security/code-scanning/5

components\Drawer.tsx

• return PWA for offline mode only as temporary step.
• create reliable caching strategy.

I think localhost storage by it self not the best solution
A small kv database like DenoKV + DenoKV-Auth can solve it
Both localstorage + server-side storage for progress would be great

Using server-side data would be great for additional ideas for the future
Like charts, top-list, course-view, ...more

Hey, so there's this glitch in the print test. When I try to print a value using var, it gives me a hard time, says it's incorrect. But if I print the value directly like with double quotes, it works like a charm, and the test is happy with me. For instance, console.log("Hi") does the trick, but console.log(var) doesn't play nice. Can you please get the programmers to sort this out? Much appreciated!

Discussed in #53

• Enabling partials
• add partails to course page /intro , /comments, ...etc

https://github.com/TeaByte/NakhlahJS/blob/main/CONTRIBUTING.md

Making a Contributing guide page

Old browser styles are messed up

like the ghost buttons and the collapse don't show when clicked

Test goes wrong!

There seems to be an issue with the initialization of preCode in the Editor component. The preCode prop is supposed to set the initial value of the editor, but it appears not to be working as expected.

Here is the relevant code snippet from Editor.tsx:

export default function Editor(props: CounterProps) {
  const [output, setOutput] = useState<string>("");
  const { showToast } = useToast();
  useEffect(() => {
    const initializeEditor = () => {
      if (window.editor) {
        window.editor.setValue(props.preCode);
      }
    };
    window.onload = initializeEditor;
    return () => {
      window.onload = null;
    };
  }, []);
}

The current code fails to accurately detect cases where a variable is declared and assigned a string value, especially when the declaration and assignment occur on separate lines. This results in false positives or inaccurate results when evaluating code submissions.

The regex pattern used in the code is insufficient to handle cases where a variable is declared and then assigned a string value elsewhere in the code. This limitation affects the reliability of the code checker.

A revised regex pattern needs to be implemented to ensure accurate detection of variable declaration and string value assignment, regardless of their placement within the code.

Kindly review and address this issue to enhance the effectiveness of the code evaluation process.

Thank you!

in route => group/[slug].tsx

at line 46 [ CourseCard ] type error:

Type '{ key: string; course: Course; }' is not assignable to type 'IntrinsicAttributes & { course: Course; isDone: boolean; }'.
  Property 'isDone' is missing in type '{ key: string; course: Course; }' but required in type '{ course: Course; isDone: boolean; }'.deno-ts(2322)
CourseCard.tsx(5, 61): 'isDone' is declared here.
(alias) function CourseCard(props: {
    course: Course;
    isDone: boolean;
}): JSXInternal.Element
import CourseCard

بعض الدروس بها مشاكل في تحقق الregex الخاص في الtestcase

مثال على المشكله:
let x = "xxx"; // صحيح
let x= "xxx"; // خطأ
let x ="xxx"; // خطأ
let x="xxx"; // خطأ
الregex المكتوب لا يراعي المسافات وايضا ال(;) في نهايه السطر في بعض الدروس
يجب تحسين الregex حتى يراعي المسافات و وجود و عدم وجود;

الدروس الي تحتاج تحسين:
http://localhost:8000/variables/uninitialized-variables

Tracking issue for:

• https://github.com/TeaByte/NakhlahJS/security/code-scanning/2