teammetallurgy / masonry Goto Github PK

Look at the following scripts and see if any need updating as models might have changed from 1.16 to 1.19:

• Stonecutter recipe script
• Blockstate scripts
• Block/Slab/Wall model scripts
• Block/Slab/Wall registry scripts
• Item model script
• Lang script
• Loot table scripts
• Tag script

This list is a work in progress.

• Clay
• Brick
• Ice
• Glowstone
• Redstone

• Stone
• Andesite
• Granite
• Diorite
• Sandstone
• Red Sandstone
• End Stone
• Purpur
• Obsidian
• Prismarine
• Dark Prismarine
• Netherrack
• Nether Brick
• Quartz

This will be the first primary batch of materials we will be adding to the mod. Each of these will have block variants.

Look into the idea of using an item slot in the Stonecutter to inset materials into a block creating new block variant options.

IE:

• Gunpowder creates Cracked
• Leaf Block or Vine creates Mossy
• Gold Nugget creates Gold Inlaid
• Iron Nugget creates Iron Inlaid
• Redstone Dust creates Redstone Inlaid
• Glowstone Dust creates Glowstone Inlaid
• Diamond creates Diamond Inlaid

Allow the pillars to be laid on their side/directional and pavers to face different directions based upon player placement.

Describe the bug
You have the Curseforge "Prevent Third-Party Distribution" setting enabled, which prevents your mod from being used on third-party launchers. Many people do not want to use the Overwolf launcher due to privacy and data-harvesting concerns, or inaccessibility on Linux, and this restriction makes it difficult for those people to use modpacks with your mod in them, as well as discouraging pack developers from including your mod. Additionally, it makes it much more difficult to host a server with this mod. For more details, see https://gist.github.com/copygirl/7d45bad739453d2be61138cebafce04c

Version:

• Mod Version: All
• Forge Version: All

Create a script that generates block models based upon how unique the block is. For example, a simple block that has all the same textures will use a different script/code than a block that has unique textures to generate the block's model file. This is because unique textured blocks have bigger model files than blocks with only one texture.

With the last release of Masonry on Twitch on the 11th of January 2020, the mods breaks anvils; they close as soon as you open them

Create a config file where users can turn features on and off if desired.

• Raw Material
• Cobbled Material
• Polished Material
• Smooth Material
• Double Brick Material
• Large Material Brick
• Small Material Brick
• Chiseled Material
• Tiled Material
• Material Column (Top, Side)
• Material Pavers
• Material Panels
• Engraved Material (Top, Side)
• Material Pillar (Top, Side)
• Rough Cut Material
• Cut Material
• Carved Material (Side - Creeper, Wither, Writing, Villager, Derp)

These are the first wave of block designs we will be adding to the mod.

Add support to JEI so players will know the smelting/stonecutting recipes. This may already be taken care of for us if JEI just looks for recipe files. Research needed.

Describe the bug
All Masonry walls are tagged as minecraft:slabs

To Reproduce
Steps to reproduce the behavior:

1. Look at what any Masonry wall is tagged as
2. See minecraft:slabs in the list of tags

Expected behavior
I expect walls to not be tagged as slabs, as vanilla walls are also not tagged as slabs.

Version (please complete the following information):\

• Mod Version [masonry-1.15.2-0.3.4]
• Forge Version [31.2.26]

Create a script that will generate stonecutter recipes for the blocks.

Is your feature request related to a problem? Please describe.
The pillars and pavers have directional facing options, but their slap counterparts don't (see green & red arrows in picture below).
Which, sure, you can work around it by using the full blocks instead, but you usually went for the slabs for a reason (like preserving resources/space, height variation, etc.)

Describe the solution you'd like
Being able to place them in both directions (west-east/south-north) based on placement - facing whatever direction the side of a block you're placing it next to is, or the player's view direction when placing it on the ground/ceiling.

Describe alternatives you've considered
Alternative (probably easier to implement) would be added variants of these blocks in these directions, so you'd have "Stone Column Slab" and "Stone Column Slab (90° Rotated)".

Additional context

Is your feature request related to a problem? Please describe.
Quark adds a few types of stone, some of which are derivatives of vanilla blocks (I may have forgotten some):

• Elder Prismarine
• Marble
• Jasper
• Limestone
• Slate
• Basalt

Describe the solution you'd like
These blocks should have the same texture variations available as blocks like stone and prismarine.

Describe alternatives you've considered
Instead of generating unique textures for each stone type, you could instead apply each new stone texture as a filter to an existing stone type, and generate them automatically.

By smelting variants they return to their base block.

Either add onto the scripts to also generate Bedrock's corresponding data files for porting the mod, or rewrite the scripts via a different system to generate both Java and Bedrock files.

Describe the bug
The item tag for masonry:stone is broken, the log states that masonry:stonecobbled is an unknown value.

To Reproduce
Steps to reproduce the behavior:

1. Load a world up
2. Check the log for tags by searching for "item tag list"
3. See error

Expected behavior
Tags should function properly.

Version:

• Mod Version 0.3.1
• Forge Version 28.1.109

Additional context

• If you want the blocks to have compatiblity with other mods, such as in recipes, there needs to be a stone tag in the forge folder in the path data/forge/tags/blocks/stone.json and in data/forge/tags/items/stone.json to define the block and it's corresponding item as stone or in the minecraft data folder for walls.

Currently, all blocks, slabs, and walls' api names do not use underscores, making them hard to read.

Create scripts that will generate the models and blockstates of walls.

Describe the bug
There is an error in what looks like recipe handling, the lag spikes cause complete freezes, with less than five seconds between spikes. Spike last anywhere from five to fifteen seconds. The error is towards the end of the attached log.

To Reproduce
Steps to reproduce the behavior:

1. Install Masonry
2. Load or create a world
3. Error

Expected behavior
The game runs smoothly.

Version:

• Mod Version 0.3.4 (1.15.2)
• Forge Version 31.2.36

Additional context
Removing Masonry fixes the problem completely.
2020-12-06-1.log
Mod list without Masonry:

Look into the possibility of adding doors. Not for every block type but a design per material or more.

Describe the bug

• Walls can be placed in a stonecutter to craft a full size block

To Reproduce
Steps to reproduce the behavior:

1. Place a wall into the stonecutter
2. See error

Expected behavior

• Walls shouldn't be in the same tag as the full block

Version:

• Minecraft v1.16.4
• Forge v35.1.13
• Masonry v0.3.6

Create scripts that will generate the models and blockstates for slab blocks.