teamsquare / s2_netbox Goto Github PK

When performing S2Netbox::Commands::Person.modify and passing in the exp_date as nil, the xml presented in the request omits this attribute, ie the raw request is:

"APIcommand=<NETBOX-API sessionid='****'><COMMAND name='ModifyPerson' num='1'><PARAMS><FIRSTNAME>Dummy</FIRSTNAME><LASTNAME>Name</LASTNAME><ACTDATE>2016-11-18 09:00</ACTDATE><UDF1>red squirrel</UDF1><UDF2>****</UDF2><ACCESSLEVELS><ACCESSLEVEL>Member AcsLvl</ACCESSLEVEL></ACCESSLEVELS><PERSONID>****</PERSONID></PARAMS></COMMAND></NETBOX-API>".

This means that if the attribute was previously set on the netbox, it is not set to null by this modify action.

Eg:

:person_id should be converted to PERSONID for all commands. Currently done at a higher level so that only some commands get this treatment.

Currently must be an array of access levels, even when specifying just a single one.

Currently you have to specify a nil, or empty Hash to the send_request method:

@result = S2Netbox::Commands::ApiVersion.get_version({}, 'session_id')

Would be much more convenient to be able to skip the arguments entirely and just send the session_id as the first parameter:

@result = S2Netbox::Commands::ApiVersion.get_version('session_id')