techforuk / mp-postcards Goto Github PK

Non-code bits and pieces required for MP postcards to go live:

• Domain (is this part of an existing BfB/tech for UK/final say site or on a new domain?)
• Static site hosting (probably depends on the domain)
• Email address to send postcards from and potentially receive emails from MPs. (probably also depends on the domain)
• Add maintainers/transfer repository to https://github.com/TechForUK
• GDPR review/approval

Currently prototype would also require funded accounts for the following:

• Netlify account (if required)
• IBM Cloud account (backend uses Cloudant DB and OpenWhisk functions)
• Sendgrid account

Need to add member_mail to https://github.com/brew4europe/mp-postcards/blob/master/backend/mp-lookup-data.json and update https://github.com/brew4europe/mp-postcards/blob/master/frontend/src/app/services/postcard-api.service.ts#L29 to remove [email protected] placeholder.

These might be the right addresses, but not sure... https://github.com/brew4europe/mp-postcards/blob/8de53df7218b27c54ea66bdc440aa89f40dec3d4/src/assets/mp-data.json

Just a nice to have but there may be some better photos on https://unsplash.com/

The length of a postcard text (i.e. message + name + address) is currently limited to 450 to line up with a postcard print/send service. The UI should show/enforce this limit or the limit should be removed.

Probably incomplete list of places the prototype diverges from the design

• no photo around postcard editing area
• layout of topic selections somewhat suspect (would also be good to have a single column on small screens)
• would be good if the choice of MP more closely mirrored the choice of topic but not sure how to fit it all in successfully (this is a bit different to the original design but I think works better with the auto suggest lookup field- yell if you disagree!)
• one design option had a separate page for entering the sender's details- is it worth splitting off from the postcard writing page where it currently is?
• page order- pick topic, pick MP, write card seems good to me but what do other people think?
• show progress- the designs show a simple progress bar under the 'Write to your MP' title
• buttons currently look awful- think the design has a flat colour but they also need hover/disabled state
• form fields need tweaking- spacing, labels, border, etc.

Anything else?

There have been a few changes recently :)

See https://github.com/TechForUK/mp-postcards/blob/master/resources/mp-data/README.md

Give some indication when MPs are being looked up, e.g. one/some 'shadow' MP boxes and/or spinner of some kind

Add a "Send me updates on this campaign and others from Best for Britain"

Is there some API/somewhere to register this kind of signup?

It should not be possible to send an incomplete postcard. The routing probably needs updating to prevent progress to the next screen before the required information has been provided

It would be great to get a few people (or more!) to try out the current prototype on various browsers/devices and open issues for any bugs they hit.

Feedback and suggestions would also be really useful.