technicpack / solder Goto Github PK
View Code? Open in Web Editor NEWSupercharge Your Modpack with Solder
License: MIT License
Supercharge Your Modpack with Solder
License: MIT License
The variable $sources does not seem to be defined for all execution paths leading up to this point.
For POST requests, the API accepts a client generated uuid, but does not validate the id is unique before attempting to use it.
When the request is made with a duplicate id, the request should be immediately rejected, and no records created.
However, currently a record is created with a different id than expected, and an SQL integrity constraint violation is returned to the consumer.
Front end is currently using the default Bulma colors; they aren't bad but they don't look very Technic or Solder like.
Would like to get some feedback on a color pallet, and possible a PR to adjust each of Bulma's primary colors into a pallet that better matches the application.
For more information about Bulma's colors: http://bulma.io/documentation/overview/variables/
Create a confirmation dialogue when deleting a modpack to prevent misclicks.
Merge this if statement with the enclosing one.
Do you want to request a feature or report a bug?
This is an unexpected behavior bug.
What is the current behavior?
An API request made with a default Accept: */*
header will return Content-Type: text/html
.
This can result in oddly unexpected behavior if for example an ajax request is made to an endpoint that requires authentication. Such a request results in a 302 Redirect
to /login
. If the user has an active session /login
will 302 Redirect
to /dashboard
and the final status code ends up being 200 Ok
, but the body is the dashboard page, not the endpoint requested.
Similarly a POST request results (after some redirects through /login) in a 415 Method Not Allowed
even though POST is allowed to the endpoint originally requested.
If the current behavior is a bug, please provide the steps to reproduce
The initial 302 Redirect
is technically the only bug and can easily be reproduced by sending a request to an endpoint which requires authentication with the Content-Type
set to application/json
curl -X POST https://solder.indemnity83.com/api/modpack -H "Accept: */*"
What is the expected behavior?
In the example above the specifically expected response is a 405 Unauthorized
error (and corresponding json error in the body)
What is the motivation / use case for changing the behavior?
Although it's not technically doing anything wrong, It is reasonable to expect that the default response type to an API request would be the application/vnd.api+json
Content-Type.
Which versions of Solder, and which browser / http server / PHP versions are affected by this issue? Did this work in previous versions of Solder?
This applies to the untagged development of Solder.
Other information (e.g. stacktraces, related issues, suggestions how to fix)
I believe the fix requires setting up (or adjusting) a middleware on the API endpoints which will translate Accept: */*
to Accept: application/vnd.api+json
.
well wouldn't it be great to have a feature where the modpack creator doesn't have to make specific directory paths, file names etc.. when uploading a mod jar to the solder repository through ftp
instead a file browser through the web browser which the mod jar can be selected and it automatically uploads and creates directories and mod slugs?
i think that would be a great feature
thank you!!
great work
This is a mental dump of the things that need to happen to get the library page (http://solder.indemnity83.com/library) polished up.
Changes to blade template (.../packages/show.balde.php)
is-danger
to input css for errors on the inputvalue="old($field)"
to each inputAnticipated Tests
Provisions have been made for file uploading in the API, but no documentation or implementation has been done.
Files are handled by the Assets model on the implementation side. Uploads should be done as PUT methods against well defined endpoints. The body of the PUT should ONLY be the file being uploaded (do not use form-multipart, or any other shortcuts).
For example, uploading a modpack logo would be:
PUT /modpack/{id}/logo
OR
PUT /modpack/{id}/assets/logo
See https://philsturgeon.uk/api/2016/01/04/http-rest-api-file-uploads/ for more information
In order to simplify the creation of modpacks; resources should be tagged for the versions of Minecraft they're compatible with. When creating a modpack build, the resource list (and resource versions) can be filtered to only show compatible resources.
I think pr #95 May have caused a regression where an admin can delete themselves.
I've checked out the latest version and installed it with your manual.
Everything went fine, until i'll try to login:
Then the site returns the error:
InvalidArgumentException in UrlGenerator.php line 304: Route [dashboard] not defined.
how can i solve that?
Currently, if you create a new build you have to re-add every single mod again.
This is rather annoying and it would be nice to implement a feature to clone builds while creating a new build.
When trying to install solder, I encounter some errors when configuring the MySQL.
When running php artisan solder:install
I encounter the error Encryption keys already exist. Use the --force option to overwrite them.
when I have a failed attempt.
The only way to get around it for me is to go back, delete the solder, re-clone it and basically start from scratch.
the --force
option does not exist.
Changes to blade template
As requested, here is a list of the endpoints solder helpers currently scrappes to do it's thing, and what exactly it uses from them:
Everything can be found in details here in terms of parameters and such:https://github.com/zlepper/go-modpack-packer/blob/angular2/source/backend/solder/solderClient.go
Allow the user to set an optional update message on the build itself rather than having to go to the Technicplatform first
After resetting a password, the user is redirected to '/home' which is invalid.
There is a funky border problem in the css or layout thats causing the sidebar not to flow as well as it should be.
Blade template changes for package management
Tests/UpdatePackageTest.php
Feature/DeletePackageTest.php
Unit/PackageTest.php
The current three tier permissions are overly complicated both for the end-user as well as for application logic.
A private modpack that has no authorized users is effectively hidden from all users. The only place it shows up outside of Solder is in the modpacks list on technicpack.net; but anybody who has access to that theoretically has an admin login to solder.
It would be significantly simpler to just have a concept of published and unpublished modpacks.
The APP_URL environment variable needs to be set in order for the application to work properly on most shared hosting providers but there are no install instructions or steps in the install script to have a user change it.
Need to get the application to look like previous versions of Solder
I set a name of the package, and a slug then hit add a package. It will then take me back to the library page, but with nothing added, even checked the database and nothing has gone there either. I have made sure the permissions were set correctly for the public folder, along with config and app. Nothing just seems to be happening, am I missing something? Or is this an issue? (could not find anyone else having this issue)
There is no current method in the GUI for linking a client to a modpack to allow clients access to private modpacks.
running php artisan solder:install
always gives me an error.
The "first" run (after removing the .env
file and running php artisan config:clear
) gives me: SQLSTATE [HY000] [2002] Connection refused
.
Running it a second time (nothing else in between) gives me the error: Base table or view not found: 1146 Table 'solder.oauth_clients' doesn't exist
(which is extremely obvious since the last attempt resulted in a failed connection).
I have checked my credentials a literal 20 times, and I'm 329523487532490% positive that they are correct.
EDIT: Might it be caused by the fact that the MySQL server is not hosted on the local machine (but rather on another machine in the network)
In the interest of both simplifying the database, non-critical information about a build was moved into a 'tags' attribute.
Its unclear what attributes of the existing API are strictly required by the existing consumers (in particular the launcher) and which are optional. If the minecraft version is required by the launcher, it should be moved to its own attribute and required.
The upgrade path will not be a simple git pull process, the changes from Laravel 4.2 to 5.2 are to significant.
I ran the command you mentioned in #72 ,but error happened!
This is the errorlog.
1.npm's errorlog
2.running commands errorlog
Please help me to solve the problem, thank you!
Closing assistant/help on top of page redirects to /settings/general
but this page does not exist.
So ehm... Finally got the thing installed, but now how do I run and access it?
I have ran php artisan up
but I can't seem to find how to access it in the browser :
Not an issue with the code per-se, just something that could be updated in the docs :)
This is a mental dump of the things that need to happen to get the library page (http://solder.indemnity83.com/library/{package}/) polished up.
Changes to blade template (.../packages/show.balde.php)
is-danger
to input css for errors on the inputvalue="old($field)"
to each inputAnticipated Tests
The $status needs to be passed through to the simpleJsonResponse to make it work, ๐
If you attempt to visit a page and don't have an active session. After logging in you're redirected to the dashboard instead of the page you originally were trying to visit.
the x on the top right of "Here is where you store all the mods, resource packs, configs or whatever else you might want to bundle into a modpack. You'll need to create a package to keep multiple versions of the same mod or resource pack together before you can start uploading files."
see title, nothing wild, just wanted to mention it ^^
There's no way to edit an oauth client after it's been created, the edit button doesn't do anything.
Do you want to request a feature or report a bug?
Bug
What is the current behavior?
Accesing the modpacks page makes solder crash, with a 500
If the current behavior is a bug, please provide the steps to reproduce
Access the following url: https://solder.indemnity83.com/modpacks
What is the expected behavior?
I should see a list of modpacks
What is the motivation / use case for changing the behavior?
That people can actually use solder.
Which versions of Solder, and which browser / http server / PHP versions are affected by this issue? Did this work in previous versions of Solder?
Solder version: fd7c9d6
Other information (e.g. stacktraces, related issues, suggestions how to fix)
Error code provided: 6205a9b8-1dc4-4ad4-bc7a-26e9ecdac57f
There doesn't seem to be a clear solution to getting chrome working on Travis-CI build environments. There's either a lot of extra steps that need to be added to the test script (seems fragile) or users just simply changing to a different driver (like Firefox or PhantomJS).
I'd really like to get the tests working with Chrome since it works so seamlessly in local development so for now I'm disabling the automated tests and inviting the community to help me troubleshoot getting the automated tests running so I can concentrate on finishing the GUI instead of spinning my wheels debugging Travis.
How can i set the location of the solder repo?
i only found in the .env file SOLDER_REPO= but that semms to be not working
data is uploaded to
/var/www/html/solderio/storage/app/public
it seems thats because oft the
'public' => [ 'driver' => 'local', 'root' => storage_path('app/public'), 'url' => env('APP_URL').'/storage', 'visibility' => 'public',
in the /var/www/html/solderio/config/filesystems.php
my repo is located at /var/www/html/repo
the vhost also directs the repo.domain.tld to there (standard solder configuration)
/Tests/AddClientTokenTest.php
/Tests/DeleteClientTokenTest.php
Method show
has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Hey, so i recently created an account for my friend on the solder install, and we were fooling around a little.
So he created another site admin without having the permissions to do so. ( he had permissions to add mods and builds ) Is the permissions system simply broken or is it just in my installation?
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.