technologiestiftung / giessdenkiez-de-osm-pumpen-harvester Goto Github PK

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Error type: Preset package is missing a renovate-config entry (@inpyjamas)

@Lisa-Stubert How can we have some python tests for this repo?

• Should it write to the repo directly?
• Should it write to the S3?
• Do we run this on Fargate like the harvester? Or on GitHub actions?
• Good place to start writing some tests for python

In the data there are some pumps:status using

• missing_beam
• locked

These should be localized before writing the json

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Repository problems

These problems occurred while renovating this repository. View logs.

• WARN: Using npm packages for Renovate presets is now deprecated. Please migrate to repository-based presets instead.

Awaiting Schedule

These updates are awaiting their schedule. Click on a checkbox to get an update now.

• chore(deps): update actions/setup-python action to v5
• chore(deps): update dependency pytest-cov to v4
• chore(deps): update dependency shapely to v2
• chore(deps): update mcr.microsoft.com/vscode/devcontainers/python docker tag to v1

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update dependency requests to v2.31.0 [security]
• chore(deps): update dependency pytest to v6.2.5
• chore(deps): update dependency geopandas to v0.14.1
• chore(deps): update dependency pandas to v1.5.3
• chore(deps): update dependency pytest-cov to v2.12.1
• chore(deps): update dependency shapely to v1.8.5.post1
• chore(deps): update python docker tag
• chore(deps): update dependency pandas to v2
• chore(deps): update dependency pytest to v7
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Currently the harvester action only works for Berlin pumps. It would be great if it could also be used by other cities.
One solution might be to make the overpass query customizable.

Any thoughts on this?

The GitHub actions commands set-output and set-state will be deprecated see this blog post --> https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

This repo is using the set-output

A fix for setting the node version could be the following action step:

jobs:
  build:
    runs-on: ubuntu-latest
    steps: 
      - name: Set nvmrc version as .env variable
        run: echo "NODE_VERSION=$(cat .nvmrc)" >> $GITHUB_ENV
            - name: Use Node.js (.nvmrc)
              uses: actions/setup-node@v3
              with:
                node-version: "${{ env.NODE_VERSION }}"

Filter the geojson before writing it to disk