Giter VIP home page Giter VIP logo

unit-testing-in-android-course's Introduction

unit-testing-in-android-course's People

Contributors

techyourchance avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

unit-testing-in-android-course's Issues

Bug in Excercise 5

In Excercise 5, in EndpointResult class, getUsername() method returns UserId.

Test Cases in Solution of Exercise 11 are not sufficiently reliable

Test Cases in Solution of Exercise 11 are not sufficiently reliable as they let my wrong implementation pass
My implementation only uses one variable for caching.
Please check

`public class FetchQuestionDetailsUseCase extends BaseObservable<FetchQuestionDetailsUseCase.Listener> {

public interface Listener {
    void onQuestionDetailsFetched(QuestionDetails questionDetails);

    void onQuestionDetailsFetchFailed();
}

private final int CACHING_TIME_OUT = 60000;
private final FetchQuestionDetailsEndpoint mFetchQuestionDetailsEndpoint;
private final TimeProvider mTimeProvider;

private final Map<String, QuestionDetails> cachedValueMap = new HashMap<>();

private long lastCachedTimestamp;

public FetchQuestionDetailsUseCase(FetchQuestionDetailsEndpoint fetchQuestionDetailsEndpoint,
                                   TimeProvider timeProvider) {
    mFetchQuestionDetailsEndpoint = fetchQuestionDetailsEndpoint;
    mTimeProvider = timeProvider;
}

public void fetchQuestionDetailsAndNotify(String questionId) {
    QuestionDetails cachedData = getValidCachedData(questionId);
    if (cachedData != null) {
        notifySuccess(cachedData);
    } else {
        mFetchQuestionDetailsEndpoint.fetchQuestionDetails(questionId, new FetchQuestionDetailsEndpoint.Listener() {
            @Override
            public void onQuestionDetailsFetched(QuestionSchema question) {
                lastCachedTimestamp = mTimeProvider.getCurrentTimestamp();
                QuestionDetails questionDetails = schemaToQuestionDetails(question);
                cachedValueMap.put(questionId, questionDetails);
                notifySuccess(questionDetails);
            }

            @Override
            public void onQuestionDetailsFetchFailed() {
                notifyFailure();
            }
        });
    }
}

private QuestionDetails getValidCachedData(String questionId) {
    QuestionDetails result = cachedValueMap.get(questionId);
    if (result != null &&
            mTimeProvider.getCurrentTimestamp() < lastCachedTimestamp + CACHING_TIME_OUT)
        return result;

    return null;
}

private void notifyFailure() {
    for (Listener listener : getListeners()) {
        listener.onQuestionDetailsFetchFailed();
    }
}

private void notifySuccess(QuestionDetails question) {
    for (Listener listener : getListeners()) {
        listener.onQuestionDetailsFetched(question);
    }
}

@NonNull
private static QuestionDetails schemaToQuestionDetails(QuestionSchema questionSchema) {
    return new QuestionDetails(
            questionSchema.getId(),
            questionSchema.getTitle(),
            questionSchema.getBody()
    );
}

}
`

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.