tehreer / sheenfigure Goto Github PK

The device table allows improved positioning for specific font sizes. It complements all positioning tables via value records and anchors.

Documentation: https://docs.microsoft.com/en-us/typography/opentype/spec/chapter2#device-and-variationindex-tables

To prevent attacks, impose an upper limit on buffer size and execution time when shaping text. For example, increment a counter on the number of executed OpenType lookups and give up when it gets excessive, and make sure that the rendering buffer does not get excessively large; check out how HarfBuzz does this. See test case GSUB-3.

A wrapper should be written for SheenFigure to support Text Rendering Tests. It would be very useful to check where the implementation stands from the Unicode community's perspective.

The current implementation only selects the provided script tag, but the OpenType specification defines a fallback mechanism. The relevant paragraph from Common Table Formats is following.
An application should use a DFLT script table if there is not a script table associated with the specific script of the text being formatted, or if the text does not have a specific script (for example, it contains only symbols or punctuation).

The code unit to glyph map is correctly produced for forward text mode. In case of backward text mode, it remains correct for 1-1 mapping. But if there are ligatures or multiple substitutions, it becomes invalid.

Support for reverse chaining contextual substitution needs to be added.

Some fonts dependent on this table:
Urdu Typesetting - http://www.cufonfonts.com/en/font/13510/urdu-typesetting
Pak Nastaleeq - http://www.urdujahan.com/font.html

Hi,

I'm curious. What's the motivation for writing this library? Why couldn't you use HarfBuzz?

With the introduction of OpenType Font Variations, device tables are intended to be replaced with their variation counterparts, such as the Variation Index Table. The support of variable positioning is a must to target modern OpenType fonts.

There should be a way to turn on / off existing features. The possibility of applying custom features should also be included.

Since travis ci does not support windows for c/cpp projects, appveyor should be integrated for that purpose.

Even though SFAlbum provides mapping from code unit to glyph index, caret positions need to be calculated manually. The process is very complex as the caret should not stop at some code units such as surrogates, or the caret adjustments should be identified in cases of character/glyph clusters. There can be ligatures whose effective caret positions should be obtained from Ligature Caret List Table.

Since caret handling is very fundamental need of text editing, having it implemented in SFAlbum would be very helpful. The logic can be borrowed from loadCharExtents method in Tehreer-Android project.

The support for getting the general category of a code point has been added in SheenBidi. It would be a good idea to use that method instead of duplicating the lookup feature here in SheenFigure as well.

In order to support variable fonts, some adjustments are required in the font class. As variable fonts can substitute the features, it is not possible to select a variable instance in the artist. There should perhaps be a function to create a variable instance of the font from the default one.