teleconsys / kyber-rs Goto Github PK

Hi there,

I never got around to answer your email / comment from earlier this year. It's great that you ported parts of our library to Rust. Did you also look at

https://github.com/RustCrypto

? Their effort might be a bit more adapted to Rust - I know some of the people who are quite active to take advantage of Rusts compiler-checking to make sure that as much as possible of the checking is done at compile time.

Best,

Linus

The struct DSS in src/sign/dss/dss.rs currently accepts two generics:

DSS<SUITE: Suite, DKS: DistKeyShare<SUITE>>

This is not necessary as SUITE needs to be the same.

Consider adding serialize and deserializeOwned traits to the generic point and scalar traits. That should be useful as they are frequently needed.

Not able to clone value from HashMap
src/share/dkg/rabin/dkg.rs#L744