telnetgmike / patchdiff2 Goto Github PK

I am using Ida Pro 6.1 and it seems patchdiff2 fails to parse the idb file. I 
would attempt to submit a patch but I do not have any experience with ida 
plugins.

Output from the console:
---------------------------------------------------
PatchDiff Plugin v2.0.8
Copyright (c) 2010, Nicolas Pouvesle
Copyright (C) 2007-2009, Tenable Network Security, Inc
---------------------------------------------------

Scanning for functions ...
parsing second idb...
Error: IDB2 parsing cancelled or failed.


Thank you,
Jacob

In sig.cpp:
sig_add_address()
{
...
s = get_max_ascii_length(tea, strtype);
...
}

The s value may be more than string's actual length. Therefore, str_hash may 
contain uncertain data so can vary between each running instance.

In diff.hpp
#define DIFF_EQUAL_SIG_HASH_CRC         1
#define DIFF_EQUAL_SIG_HASH_CRC_STR     2

I think they should switch the value with each other. Then,


In diff.cpp sig_equal()
if (type <= DIFF_EQUAL_SIG_HASH_CRC)

This will cover DIFF_EQUAL_SIG_HASH_CRC_STR. That'll be right.