Giter VIP home page Giter VIP logo

spoilers's People

Contributors

applehat avatar carmenbianca avatar dependabot[bot] avatar kizule avatar must-not-code avatar ovvldc avatar petermarkley avatar rail01 avatar telshin avatar valeryan avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

spoilers's Issues

Typo in spoilers.js

Typo in js/spoilers.js at 11 and 13 lines:
$parent.children('.spolers-body:visible').length
instead of
$parent.children('.spoilers-body:visible').length.

mobile frontend

Hello! Am i right that this extension will not work for mobile version, with mobile frontend installed?

Spoiler 'show' attribute does not work

Example:

Usage example

This spoiler created as:

<spoiler show="цитата (показать)" hide="цитата (скрыть)">
A lot of text
</spoiler>

but works as Показать спойлер / цитата (скрыть)

Messed markup

If spoiler is used with indentation (for example :<spoiler>blabla</spoiler>) page markup is messed up and sidebar is not usable.

It looks like this.

Spoiler Extension on MW 1.30

I've installed this extension on MW 1.30 and, when used on a page, one message line "Array ( [show] => see details [hide] => hide details [text] => 'UNIQ--DPL-00000001-QINU' )" is displayed on upper side.

Could it be fixed ?

addModules with non-array argument was deprecated in MediaWiki 1.38

Just realized we are seeing these errors on our Mediawiki Virtual Server.

[Tue Oct 18 08:31:29.153596 2022] [proxy_fcgi:error] [pid 2115157:tid 140118157399808] [client 162.158.62.216:56338] AH01071: Got error 'PHP message: PHP Deprecated: Use of ParserOutput::addModules with non-array argument was deprecated in MediaWiki 1.38. [Called from Spoilers\SpoilersHooks::spoilerMagicTag in /home/wiki/public_html/extensions/Spoilers/SpoilersHooks.php at line 62] in /home/wiki/public_html/includes/debug/MWDebug.php on line 377'
[Tue Oct 18 08:31:56.194557 2022] [proxy_fcgi:error] [pid 2115079:tid 140118476191488] [client 162.158.62.18:23382] AH01071: Got error 'PHP message: PHP Deprecated: Use of ParserOutput::addModules with non-array argument was deprecated in MediaWiki 1.38. [Called from Spoilers\SpoilersHooks::spoilerMagicTag in /home/wiki/public_html/extensions/Spoilers/SpoilersHooks.php at line 62] in /home/wiki/public_html/includes/debug/MWDebug.php on line 377'

We are running the below versions with version 2.2.0 of the extension.

MediaWiki 1.38.2
MariaDB 10.3.34-MariaDB-0ubuntu0.20.04.1

I have tested and the extension works as expected however it does log the log error.

Mediawiki extension Spoiler using function in deprecated way

[Thu Oct 19 09:01:24.209822 2023] [proxy_fcgi:error] [pid 412528:tid 139637366925056] [client 172.70.115.32:41262] AH01071: Got error 'PHP message: PHP Deprecated: Use of ParserOutput::addModules with non-array argument was deprecated in MediaWiki 1.38. [Called from Spoilers\SpoilersHooks::spoilerMagicTag in /home/wiki/public_html/extensions/Spoilers/SpoilersHooks.php at line 62] in /home/wiki/public_html/includes/debug/MWDebug.php on line 382', referer: https://wiki.pcsx2.net/Category:Turn-based_strategy

Change is tabled for Mediawiki 1.42.as per https://phabricator.wikimedia.org/T305161.

Add new {{ParserFunction}}

  • Add {{ParserFunction}} for spoilers
  • Mark for spoilers are deprecated (MW log, )
  • Deprecate any version below MW 1.25, create a branch for < 1.25 code
  • Test issue #20
  • Test issue #19
  • Test issue #8

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.