E.g. for SignVoteRequest (see tendermint/tmkms#61)

This happens only if the type is registered. This part is the reason:

At this point the var encoded_len doesn't hold the total encoded length but only the prefix bytes length (4). We'd need to skip ahead at an earlier point. In general this needs way more testing, too.

Is amino_rs fully compatible with go-amino?

Why is the version of this library 0.6.0 on crates.io but the version number in the manifest on master branch is 0.5.0.

Thanks,
Tobin.

• it's easier to discuss failing builds / test (one can link to test output)
• never miss a failing test etc.
• more complicated to use circleci & rust
• no need to wait until someone grants travis access (I've submitted an access request for the whole org, still pending), as we can grant travis access to our forks immediately

See #4 (comment)

Going for circle-ci for now.

For registered types this lib currently just skips over the prefix bytes. This assumes the caller knows which types to decode on the other side. In reality the user doesn't necessarily know which implementation of a certain type he needs to decode. This was a little hack to be able to unblock building a MVP-kms. In the kms, we only differentiate between a few types and the logic for this currently lives there: https://github.com/tendermint/kms/blob/0ce1408bd3c99367f6712d6434252a556b712065/src/rpc.rs#L44-L97

This should be handled by this amino library here instead. Similarly to the go-lang implementation:
https://github.com/tendermint/go-amino/blob/master/codec.go

Also, and of lower priority, this library does not deal with disambigaution bytes yet (only with prefix bytes). This should be implemented too.

Add tests that make sure amino_rs and go-amino are interoperable

The macro-generated code always checks the top-level attributes of the wrapping message for is_registered instead of on a per field basis :-/

We haven't noticed that so far because the only place this feature was (successfully) used was for PubKeyMsg which contains only one field which also happen to be registered.

Additionally, this length computation is wrong:

prost uses a custom derive macro to handle encoding and decoding types, which means that if your existing Rust type is compatible with Protobuf types, you can serialize and deserialize it by adding the appropriate derive and field annotations.

See https://github.com/danburkert/prost#serializing-existing-types

We want the same thing but for amino messages. @zmanian already started working on this here: https://github.com/tendermint/amino_rs/blob/master/amino-derive/src/lib.rs

Implement encodings for simple types like integers, string and bytestrings

We've changed the crate name from prost to prost-amino. Some of the tests and prost-derive still use prost internally.

Compare

with
https://github.com/tendermint/go-amino/blob/c7424fdd930314cc4c344b331e112dac004718ef/encoder.go#L63-L75
and
https://github.com/tendermint/go-amino/blob/c7424fdd930314cc4c344b331e112dac004718ef/decoder.go#L42-L62

Need to remove these shift operations to match with go-amino.

For instance:

package main

import (
	"github.com/tendermint/go-amino"

	"bytes"
	"encoding/hex"
)

func main() {
	b := new(bytes.Buffer)
	amino.EncodeInt32(b, 1)
	println(hex.Dump(b.Bytes()))
}

prints
00000000 00 00 00 01 |....|
while the corresponding rust buffer after calling encode_int32 is
[0, 0, 0, 2]

after changes of this PR it's
[0, 0, 0, 1] 🎉

(We definitely need to autom. this #5 )

Alternative: replace amino_rs with this prost! fork.

Update: We can close this as soon as #12 is merged!

In particular the changes from 0.9.10 to the latest 0.10.1. An upcoming release is planned will contain a few additional breaking changes that should affect amino_rs (skipping over default values, incl. time structs).

• do not encode empty structs, unless explicitly enforced via amino:"write_empty"
• do not encode zero values in EncodeTime
• removed struct term (missing in changelog?)
• proto3 compatibility:
  • BigEndian -> LittleEndian
  • [u]int[64/32] is (signed) Varint by default, "fixed32" and "fixed64" to use 4 and 8 byte types
  • Amino:JSON [u]int64 and ints are strings (might be irrelevant for the kms)

related: tendermint/tmkms#32