tercioo / open-raid-library Goto Github PK

openRaidLib.RequestAllData() executes without error and will return true, but do not get any callbacks at all. The only way openRaid gets updated is when exiting combat.

Hello Tercioo! Great Work. We were wondering if you could update the LIB_OPEN_RAID_ENCHANT_SLOTS array with the value "[INVSLOT_WAIST] = true" (line 125 of the ThingsToMantain_Dragonflight.lua file) because in the new patch 10.1 there is a new enchant for belts (Shadowed Belt Clasp) that we would like to track. Thank you very much and keep up the great work!

Hi,

Deathmark from Assassination Rogue is missing.

So I have the following code to fetch keystone data from other players within a WeakAura:

a.LOR = LibStub:GetLibrary("LibOpenRaid-1.0")
a.LOR.WipeKeystoneData()
a.LOR.RequestKeystoneDataFromParty()

Then I iterate through the users to display the keystone. What is interesting is that when I call the WipeKeystoneData (so I can get fresh keystone data), it is then not getting any data from the RequestKeystonesDataFromParty. When I remove WipeKeystoneData, the the other command functions properly and fetches the needed data.

I didn't see a discord for help, but was wondering if this was intentionally designed or a bug. If it is intentionally, what would a workaround be to refresh all party members' keystone data + your own keystone data?

I logon to game and see this error:

2x Details/Libs/LibOpenRaid/Functions.lua:450: attempt to concatenate local 'itemName' (a nil value)
[string "@Details/Libs/LibOpenRaid/LibOpenRaid.lua"]:1613: in function AddUnitGearList' [string "@Details/Libs/LibOpenRaid/LibOpenRaid.lua"]:1018: in function <...faceDetails/Libs/LibOpenRaid/LibOpenRaid.lua:1010> [string "=[C]"]: in function xpcall'
[string "@Details/Libs/LibOpenRaid/LibOpenRaid.lua"]:546: in function <...faceDetails/Libs/LibOpenRaid/LibOpenRaid.lua:536>

I was wondering if there was any plan to support pets in the unit cooldowns ?
Can't track warlocks interrupts for instance at the moment.

Is it possible to add talent rank for talents when using GetUnitInfo?
Edit:
Some talents are reducing the cooldown of other spells depending of the rank.
One option would be to add an extra arg that return the talent ranks so we dont mess up the old API or it can be changed to something like the conduits arg.

unitInfo = {
.specId = number
.specName = string
.role = string
.renown = number
.covenantId = number
.talents = {talentId, talentId, talentId, ...}
.talentsRank = {talentRank, talentRank, talentRank, ...} -- 1 if only one rank or rank value , in the same order as the talents
.pvpTalents = {talentId, talentId, talentId}
.conduits = {spellId, conduitLevel, spellId, conduitLevel, spellId, conduitLevel, ...}
.class = string class eng name 'ROGUE'
.classId = number
.className = string class localized name
.name = string name without realm
.nameFull = string name with realm 'unitName-ServerName'
}

When using the call back function for an "KeystoneUpdate" event as shown in the docs.txt file. The unitName parameter seems to be always nil.

function MyAddonObject.OnKeystoneUpdate(unitName, keystoneInfo, allKeystoneInfo)
    local mapName = C_ChallengeMode.GetMapUIInfo(keystoneInfo.mythicPlusMapID)
    print(unitName .. " has a " .. keystoneInfo.level .. " keystone for map " .. mapName  .. ".")
end

--registering the callback:
openRaidLib.RegisterCallback(MyAddonObject, "KeystoneUpdate", "OnKeystoneUpdate")

As far as I could tell with some testing the first parameter was always keystoneInfo, which doesn't contain any name information of WHOSE data it is. Combing through allKeystoneInfo is also to much when only interested in party data.

Am I missing something with the unitName parameter?

Says that I don't have any enchants or gems, while being fully enchanted and gemmed.

• Metamorphosis (VDH)
• Touch of the Magi (Arcane)
• Shifting Power
• 152262 on pal isnt resolved to a name
• Deathmark but that's already covered by #43

Hi!
Amazing weakaura!
I'm currently setting up a vuhdo profile for my main buff targets and the weakaura is just what i needed to complete it.
But if i for example have 2 Dev Evokers and i only have one of them in my vuhdo frame to buff 1 him, DR from the other Evoker will be displayed on my ElvUI Raidframe instead. Is there any way to only display stuff on the Vuhdo frame?
Thanks alot for the help!

It seems that the addon is sending wrong cooldown info after a /reload or when changing zone and stuff , the problem seems to be with AceComm-3.0 , i think because of the ChatThrottleLib , it delays the sending of cooldown updates from 3 to 8 seconds so all the cooldowns are 3 to 8 seconds behind, tested without the AceComm-3.0 and it works ok.

The problem with is if you /reload in the middle of a Arena/Dung/Raid etc .. .or you get a crash and you have to log in again you will send delayed cooldown data to everybody.

What i was thinking is to use GetServerTime() (seems to work fine now) to keep the cooldowns data in sync, for compatibility reasons an workaround could be something like:

      local serverTime = GetServerTime()
      local data = data .. ",Q," .. serverTime
...

for cooldowns sending part, doing something like this seems not to interfere with the actual code and we can do, for ex, something like this for the receiving part:

            local localServerTime = GetServerTime()
            local timeLeft = start + duration - GetTime() - (localServerTime  - serverTime )
...

Ofc , ideal would be to make everything to use GetServerTime() instead of GetTime() or maybe a GetTime() sync before cooldown updates ( i like the GetServerTime() option more) .

Hey, I think this library is really a great way to share data. I'm currently working on a WeakAura that checks for missing enchants and stuff, and would love to add a soulbind/conduit checker if correct conduits and soulbind are selected for the spec.

I'd need the soulbindID and the state of the conduit. I see that you already grab soulbindID and could easily grab the conduit state, but I don't know how to best implement it to fit your style. Do you think you could add that?

Thanks a lot!

Are there any plans to support BCC (and upcoming Wrath) builds? We'd be interested in including the library in PallyPower to get spec information for auto-buff.

We'd prefer a library that's already widely available to clients over a homebrew solution.

i noticed that Wake of Ashes is missing, should be added since it works as a CC even with only 30s CD

Missing Cauterizing Flame for Augmentation evoker.

I see that it doesnt work for Wotlk or Classic , any plans on enabling it for them ?

Hi there,
could you please add Pillar of Frost (frost dk 1 min cd)?

Thanks for you work.

If I use a cooldown ability, Barkskin is what I tested with, then while the ability is on CD /reload I don't receive a callback for CooldownUpdate when Barkskin comes off Cooldown.

All other abilities trigger the callback on use and on ready even while Barkskin is on cooldown.

Subsequent uses of Barkskin get the proper callbacks. Only when /reloading does the on ready callback not occur.

I am using open raid Library in a Weakaura.
https://wago.io/HSy3ggpZg

Relevant code at the top of Init and line 13 in Trigger 1

Hello!

I noticed that Incapacitating Roar is not working properly for Guardian Druids.

Hey - love the library. I'm currently having a problem with sigil charges for demon hunters not being tracked correctly. Probably an issue since they received their rework. Not sure whether I'm on the right track, but in ThingsToMantain_Dragonflight.lua they look like this (example).

[207684] = {cooldown = 90, duration = 12, specs = {581}, talent = false, charges = 1, class = "DEMONHUNTER", type = 8}, --Sigil of Misery

This seems to imply it's only setup for 1 charge? Could you look into this?
Thanks so much.

I am thinking to use this lib in my addon but I see that some spells are missing like Grounding totem , Skyfury totem (i checked on my resto shaman) , not sure if its only the pvp spells that are missing or just some random spells.

Is is possible to add more spells without modifying ThingsToMantain_Dragonflight.lua ? Or do you consider to update the spells list?
I am not sure what the behavior will be if for example there are two or more addons that are using the lib, i want to sync some spells when in party/raid that are not in the list.