terraform -version
Terraform v0.14.6
+ provider registry.terraform.io/hashicorp/aws v3.28.0
lsb_release -a
Description:    CentOS Linux release 8.3.2011
Release:        8.3.2011

While practicing with Terraform in my personal AWS environment, I used the following code while working on Terraform functions:

resource "aws_key_pair" "loginkey" {
  key_name   = "login-key"
  public_key = file("${path.module}/id_rsa.pub")
}

As is usually my habit when working with ssh-keygen, I generated an ed25519 key. Upon attempting to use it, Terraform greeted me with the following error:

aws_key_pair.loginkey: Creating...

Error: Error import KeyPair: InvalidKey.Format: Key is not in valid OpenSSH public key format
        status code: 400, request id: 54d0c365-8ab5-49b5-8420-9108084eb183

It did not take long at all to find and subsequently remember that AWS only supports RSA keys as of this time. ed25519, ECDSA, and DSA keys all result in the same error, which I have just verified. Curiously enough, the first link below mentions that AWS uses 2,048 bit RSA keys, but I have just used Terraform to use 4,096 and 8,192 bit RSA keys, insert them into my account's Key Pairs, and connect to the resulting EC2 instances just fine as long as they are newer, such as RHEL 8. Amazon Linux 2 errors out, curiously enough.

Amazon EC2 key pairs and Linux instances (docs.aws.amazon.com)

Unanswered Amazon forums thread of people requesting ed25519 key support (forums.aws.amazon.com)

Would it be possible to update the error handling for this particular module such that, if it detects a non-RSA key being imported, it tells the user something along the lines of "Only RSA SSH keys are supported as of this time. Please reference an RSA key to function properly with AWS EC2 instances."

Hello!

I have problem with new update

fran@fran-X580VD:~/mesa-dinero/dev/back$ terraform init
Initializing modules...
Downloading terraform-aws-modules/key-pair/aws 0.3.0 for key_pair2...

• key_pair2 in .terraform/modules/key_pair2/terraform-aws-modules-terraform-aws-key-pair-06fa6de

Initializing the backend...

Initializing provider plugins...

• Checking for available provider plugins...

No provider "aws" plugins meet the constraint "> 2.23,> 2.46.0,~> 2.53".

The version constraint is derived from the "version" argument within the
provider "aws" block in configuration. Child modules may also apply
provider version constraints. To view the provider versions requested by each
module in the current configuration, run "terraform providers".

To proceed, the version constraints for this provider must be relaxed by
either adjusting or removing the "version" argument in the provider blocks
throughout the configuration.

Error: no suitable version is available

Perhaps you should consider placing a mandatory input var.region where module can be cross refferanced.

  required_version = ">= 0.12"
}

provider "aws" {
  region = var.region
}

variable "region" {
  description = "AWS Region, .g. 'eu-west-1'"
}

Usage:

module "north_1-key_pair_bastion" {
  source     = "./modules/key-pair"
  region     = "eu-north-1"
  key_name   = "bastion"
  public_key = "ssh-rsa xxxxxxxxx [email protected]"
}

We recently found a need to create a keypair with every VM that we create. So there were two updates to the module.
One was to support count in this module and use this array of keys in the VM module.

resource "aws_key_pair" "this" {
  count      = var.key_count
  key_name   = var.key_count == 1 ? var.key_name : format("%s-%03d", var.key_name, (count.index + 1))
  public_key = var.ssh_public_key
  tags = var.tags
}

I can create a PR for the same, if you feel there is a need to entertain it.

Description

Receiving an error with the deprecated list function when upgrading to Terraform binary v0.15

Versions

Terraform v0.15.0
on linux_amd64

• provider registry.terraform.io/hashicorp/aws v3.7.0
• provider registry.terraform.io/hashicorp/null v3.1.0
• provider registry.terraform.io/hashicorp/random v3.1.0
• provider registry.terraform.io/hashicorp/tls v3.1.0

Reproduction

Steps to reproduce the behavior:
terraform init
terraform plan

Code Snippet to Reproduce

Error: Error in function call
│ 
│   on .terraform/modules/test_ssh_keypair.tls_private_key/outputs.tf line 2, in output "algorithm":
│    2:   value = concat(tls_private_key.key.*.algorithm, list(""))[0]
│ 
│ Call to function "list" failed: the "list" function was deprecated in Terraform v0.12 and is no longer available; use tolist([ ... ]) syntax to write a literal list.

 Error: Error in function call
│ 
│   on .terraform/modules/tls_private_key/outputs.tf line 2, in output "algorithm":
│    2:   value = concat(tls_private_key.key.*.algorithm, list(""))[0]
│ 
│ Call to function "list" failed: the "list" function was deprecated in Terraform v0.12 and is no longer available; use tolist([ ... ]) syntax to write a literal list.

Additional context

The error is replicated a number of times in both the real and the test modules

if i create like this how can I get private key ?

resource "random_pet" "this" {
  length = 2
}

resource "tls_private_key" "this" {
  algorithm = "RSA"
}

module "key_pair" {
  source = "../../modules/aws/key-pair"

  key_name   = random_pet.this.id
  public_key = tls_private_key.this.public_key_openssh

  tags = {
    Terraform = "true"
  }
}

The code I'm using. If key-name already exists, don't try to create it, it will produce an error. If it exists, just use it:
module "key_pair" {
source = "terraform-aws-modules/key-pair/aws"
key_name = "surfkey"
public_key = file("~/.ssh/surfkey.pub")
create_key_pair = false
}

Error:

terraform init

Initializing modules...
Downloading terraform-aws-modules/key-pair/aws 0.6.0 for key_pair...

Error: Failed to download module

Could not download module "key_pair" (main.tf:165) source code from
"git::https://github.com/terraform-aws-modules/terraform-aws-key-pair?ref=v0.6.0":
error downloading
'https://github.com/terraform-aws-modules/terraform-aws-key-pair?ref=v0.6.0':
git must be available and on the PATH.