tesla / m2eclipse-mavenarchiver Goto Github PK

If the POM contains non-ASCII characters in the archive configuration of the maven-jar-plugin, m2e generates a MANIFEST with garbled characters. I just reproduced this effect with a freshly unpacked eclipse 4.4 SR1 distribution, a fresh workspace and a fresh project on a Windows 7 64 Bit machine.

The relevant part of the POM was:

<project>
<modelVersion>4.0.0</modelVersion>
<groupId>manifestenc</groupId>
<artifactId>manifestenc</artifactId>
<version>0.0.1-SNAPSHOT</version>
<name>manifestenc</name>
<description>Test: ÄÖÜ âêô €</description>

<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<version>2.5</version>
<configuration>
<archive>
<manifestEntries>
<Implementation-Title>${project.description}
</Implementation-Title>
<other-test>Something beyond ASCII: äöüß áéâê</other-test>
<test-counter>3</test-counter>
</manifestEntries>
</archive>
</configuration>
</plugin>
</plugins>
<pluginManagement>
... (enable org.sonatype.m2e.mavenarchiver.jararchiverconfigurator via
lifecycle mapping) ...
</pluginManagement>
</build>
</project>

The resulting manifest was:

Manifest-Version: 1.0
Implementation-Title: Test: ￃﾄￃﾖￃﾜ ￃﾢￃﾪￃﾴ ￢ﾂﾬ
other-test: Something beyond ASCII: ￃﾤￃﾶￃﾼￃﾟ ￃﾡￃﾩￃﾢￃﾪ
Build-Jdk: 1.7.0_51
Built-By: rgross-hardt
Created-By: Maven Integration for Eclipse
test-counter: 3

The bug does not occur, when the maven CLI is used:

Manifest-Version: 1.0
Implementation-Title: Test: ÄÖÜ âêô €
Built-By: rgross-hardt
Build-Jdk: 1.7.0_51
other-test: Something beyond ASCII: äöüß áéâê
Created-By: Apache Maven 3.1.1
test-counter: 3
Archiver-Version: Plexus Archiver

I think the problem has been around since eclipse 3.7 (where I first noticed strange characters in an about dialog derived from MANIFEST attributes), but is definitely also in eclipse 4.3.

I tried to reproduce the problem with a new unit test based on the unit tests in org.sonatype.m2e.mavenarchiver.tests, but the generated MANIFEST were OK. So I opened a new issue on https://bugs.eclipse.org/bugs/show_bug.cgi?id=454059, but they sent me here.

I migrated my eclipse version from 2021-12 to 2022-03.
On every project I tried to open I get one or more maven build problem.
If I reopen the same project with the 2012-12 (I saved it) it works again .
How can I solve that blocking issue ?
Tks
`Description Resource Path Location Type
null (org.apache.maven.plugins:maven-jar-plugin:3.2.2:jar:default-jar:package)

org.eclipse.core.runtime.OperationCanceledException
at org.eclipse.core.runtime.SubMonitor.checkCanceled(SubMonitor.java:602)
at org.eclipse.core.internal.resources.Resource.setDerived(Resource.java:1620)
at org.eclipse.m2e.core.internal.M2EUtils.createFolder(M2EUtils.java:86)
at org.sonatype.m2e.mavenarchiver.internal.AbstractMavenArchiverConfigurator.writePom(AbstractMavenArchiverConfigurator.java:840)
at org.sonatype.m2e.mavenarchiver.internal.AbstractMavenArchiverConfigurator$1.build(AbstractMavenArchiverConfigurator.java:180)
at org.eclipse.m2e.core.internal.builder.MavenBuilderImpl.build(MavenBuilderImpl.java:135)
at org.eclipse.m2e.core.internal.builder.MavenBuilder$1.method(MavenBuilder.java:169)
at org.eclipse.m2e.core.internal.builder.MavenBuilder$1.method(MavenBuilder.java:1)
at org.eclipse.m2e.core.internal.builder.MavenBuilder$BuildMethod.lambda$1(MavenBuilder.java:114)
at org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:182)
at org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:117)
at org.eclipse.m2e.core.internal.builder.MavenBuilder$BuildMethod.lambda$0(MavenBuilder.java:105)
at org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:182)
at org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:156)
at org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:103)
at org.eclipse.m2e.core.internal.builder.MavenBuilder$BuildMethod.execute(MavenBuilder.java:88)
at org.eclipse.m2e.core.internal.builder.MavenBuilder.build(MavenBuilder.java:198)
at org.eclipse.core.internal.events.BuildManager$2.run(BuildManager.java:860)
at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:45)
at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:232)
at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:281)
at org.eclipse.core.internal.events.BuildManager$1.run(BuildManager.java:334)
at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:45)
at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:337)
at org.eclipse.core.internal.events.BuildManager.basicBuildLoop(BuildManager.java:392)
at org.eclipse.core.internal.events.BuildManager.build(BuildManager.java:417)
at org.eclipse.core.internal.events.AutoBuildJob.doBuild(AutoBuildJob.java:161)
at org.eclipse.core.internal.events.AutoBuildJob.run(AutoBuildJob.java:255)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)
pom.xml /izpack-custom line 4 Maven Build Problem`

@eclipse 4.4 M3(m2e 1.5.0.20131109-1116)
each time we build our maven project(via Build Automatically, not from maven command)

META-INF/MANIFEST.MF will also be generated at target folder with specified maven-jar-plugin manifestEntries configuration

but eClipse 4.4 M7(m2e 1.5.0.20140505) no longer generate META-INF/MANIFEST.MF (via Build Automatically)

is this a bug or behavior changed(work as design) ?

@see https://bugs.eclipse.org/bugs/show_bug.cgi?id=434818

Environment:
OS: Windows 7 (64bit)
Eclipse: Kepler SR2 (Java EE version, 64bit)
JDK: Oracle JDK 1.7

Steps to re-produce:

1. open eclipse with a new workspace
2. import the sample project as maven project which can be downloaded from provided link

There will be a maven configuration problem after the build completes. Check the attached screenshot.

Screenshot:

Sample project to re-produce this issue:
https://drive.google.com/uc?id=0B_bgjujj3QfUdWdFZk1hOGdUVE0&export=download

Error:

org.apache.maven.archiver.MavenArchiver.getManifest(org.apache.maven.project.MavenProject,
org.apache.maven.archiver.MavenArchiveConfiguration)
Resource: pom.xml
Path: /<my eclipse project>
Line: 1
Type: Maven Configuration Problem

Referencing the m2e-users list..which mentioned the m2e archive uses reflecting to use methods from maven-archiver....

On a multi-user system Eclipse might report a "permission denied"
message for a pom.xml file. This is known to be caused by
a workaround in mavenarchiver. For more details, see
https://dev.eclipse.org/mhonarc/lists/m2e-users/msg04160.html

mavenarchiver creates a directory fakerepo/ in ${"java.io.tmpdir"}
with 755 permissions in Linux. As a result, other users will not be
able to write to this directory.

I'm using the latest version (https://otto.takari.io/content/sites/m2e.extras/m2eclipse-mavenarchiver/0.17.1/N/LATEST/) of the m2e-archiver posted here (#8) which fixed an error for maven-jar-plugin 3.0.0.
When I switch to latest version 3.0.1 I get a new error: org.codehaus.plexus.archiver.jar.Manifest.write(java.io.PrintWriter)

Similar problem? Can you take a look at it?

I'm using:

• Eclipse: 4.5.2.20160218-0600
• m2e connector for mavenarchiver: 0.17.1.201605251832
• JDK: 1.8.0_71 (32bit)