CI: update upload-artifact action about teslamate HOT 15 CLOSED

Think this is causing errors in:
https://github.com/teslamate-org/teslamate/actions/runs/8064800308/job/22029399915

Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

Found something here that could explain it:
actions/upload-artifact#478

from teslamate.

Finally working with v4 action, https://github.com/teslamate-org/teslamate/actions/runs/8094659397?pr=3708

@micves fyi

from teslamate.

Thanks a lot, that looks like it was a rough one :|

from teslamate.

Thanks, GitHub Actions are hard to test locally (even if it is possible in most cases).
Will take a deeper look into the naming. I was aware of the breaking change and considered it as not relevant, as we use it differently.

from teslamate.

Thanks for looking into it. There are many small steps in CI at the moment, but at some point it's all going to be sorted out :)

from teslamate.

fixed with 39ab647
Unfortunately not tested, as for security reasons changes in .githubfolder are excluded for our automatic ci

from teslamate.

It looks like it works on master, but still not on PRs :(
https://github.com/teslamate-org/teslamate/actions/runs/8082839912/job/22084555821

in the log it seems to ignore ${{ matrix.runs-on }}

2024-02-28T15:27:19.5466184Z ##[group]Run actions/upload-artifact@v4
2024-02-28T15:27:19.5466740Z with:
2024-02-28T15:27:19.5467093Z name: single-digest-

from teslamate.

Test with #3702

from teslamate.

As I needed to adopt the digest naming again and our security is working, new test with #3703

from teslamate.

Good thing our security guards works perfectly. Bad thing: testing GitHub actions is now a pain.

from teslamate.

Test with #3704

from teslamate.

Ok test looks good for the upload now, the merging is still failing: https://github.com/teslamate-org/teslamate/actions/runs/8089110554/job/22104597849?pr=3485

from teslamate.

new test for merging with #3705

from teslamate.

Merging works as expected, as path is not supported anymore, the working directory needs to be set beforehand, so follow-up steps can use the downloaded artifacts directly

from teslamate.

new test with #3706

from teslamate.