tfarcenim / daves-potioneering Goto Github PK

License: Creative Commons Zero v1.0 Universal

Java 100.00%

daves-potioneering's Introduction

MultiLoader Template

This project provides a Gradle project template that can compile mods for both Forge and Fabric using a common sourceset. This project does not require any third party libraries or dependencies. If you have any questions or want to discuss the project join our Discord.

Getting Started

IntelliJ IDEA

This guide will show how to import the MultiLoader Template into IntelliJ IDEA. The setup process is roughly equivalent to setting up Forge and Fabric independently and should be very familiar to anyone who has worked with their MDKs.

Clone or download this repository to your computer.
Configure the project by editing the group, mod_name, mod_author, and mod_id properties in the gradle.properties file. You will also need to change the rootProject.name property in settings.gradle, this should match the folder name of your project, or else IDEA may complain.
Open the template's root folder as a new project in IDEA. This is the folder that contains this README file and the gradlew executable.
If your default JVM/JDK is not Java 17 you will encounter an error when opening the project. This error is fixed by going to File > Settings > Build, Execution, Deployment > Build Tools > Gradle > Gradle JVMand changing the value to a valid Java 17 JVM. You will also need to set the Project SDK to Java 17. This can be done by going to File > Project Structure > Project SDK. Once both have been set open the Gradle tab in IDEA and click the refresh button to reload the project.
Open the Gradle tab in IDEA if it has not already been opened. Navigate to Your Project > Common > Tasks > vanilla gradle > decompile. Run this task to decompile Minecraft.
Open the Gradle tab in IDEA if it has not already been opened. Navigate to Your Project > Forge > Tasks > forgegradle runs > genIntellijRuns. Run this task to set up run configurations for Forge.
Open your Run/Debug Configurations. Under the Application category there should now be options to run Forge and Fabric projects. Select one of the client options and try to run it.
Assuming you were able to run the game in step 7 your workspace should now be set up.

Eclipse

While it is possible to use this template in Eclipse it is not recommended. During the development of this template multiple critical bugs and quirks related to Eclipse were found at nearly every level of the required build tools. While we continue to work with these tools to report and resolve issues support for projects like these are not there yet. For now Eclipse is considered unsupported by this project. The development cycle for build tools is notoriously slow so there are no ETAs available.

Development Guide

When using this template the majority of your mod is developed in the Common project. The Common project is compiled against the vanilla game and is used to hold code that is shared between the different loader-specific versions of your mod. The Common project has no knowledge or access to ModLoader specific code, apis, or concepts. Code that requires something from a specific loader must be done through the project that is specific to that loader, such as the Forge or Fabric project.

Loader specific projects such as the Forge and Fabric project are used to load the Common project into the game. These projects also define code that is specific to that loader. Loader specific projects can access all of the code in the Common project. It is important to remember that the Common project can not access code from loader specific projects.

daves-potioneering's People

Contributors

Stargazers

Watchers

Forkers

wintersteve25 energizedblast unroman derozero

daves-potioneering's Issues

[Forge 1.20.1] Bug in coated weapons?

I was testing the coated weapons, but it seems that it does not work on weapons from other mods, only on vanilla swords, is this intentional?

Forge: 1.20.1-47.2.0
Dave's Potioneering: 1.20.1-11

Bottom of reinforced cauldron becomes transparent when holding liquid

Intentional?

Using Rubidium, if that means anything.

Item Group translation key missing

The Daves Potioneering Item Group name is showing up like "itemGroup.davespotioneering...." instead of a translated name.

using: Dave's Potioneering 0.12 - Fabric 1.19.2

Fabric Filename Listed As Forge Supported Modloader

[Fabric 1.20.1] Items are not loaded into creative menu or JEI

See title. The items do not appear in the creative inventory nor JEI, but recipes and commands still work. Must be an error with the creative inventory setup

Crash when opening Tab in Creative

Seems to be a rendering item error.
crash-2022-10-17_13.01.05-client.txt

Thank you for the speedy responses, by the way.

[Issue] Problem loading mod?

Hi! I want to use this mod but I would like to configure its features for my modpack. The thing is... the mod is not appearing in ModMenu o_o And also, inside config folder, the file is empty. I'm using MC 1.19.2 with Fabric 0.14.13.

Im sending you the config and the log to see if you can tell what could be the possible error. Thank you! : )
davespotioneering.json5
latest.log

1.20.1 server crash

[Incompatibility] Not compatible with LevelZ

Game version: 1.18.2 fabric
Mod version: 1.0.9
Description(generated by mixin conflict helper):
LevelZ is conflicting with Dave's Potioneering.

Stacktrace

org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: @At("INVOKE_ASSIGN") on net/minecraft/class_1812::finishUsingMixin with priority 1000 cannot inject into net/minecraft/class_1812::method_7861(Lnet/minecraft/class_1799;Lnet/minecraft/class_1937;Lnet/minecraft/class_1309;)Lnet/minecraft/class_1799; merged by tfar.davespotioneering.mixin.PotionItemMixin with priority 1000 [PREINJECT Applicator Phase -> levelz.mixins.json:item.PotionItemMixin from mod levelz -> Prepare Injections ->  -> localvar$znj000$finishUsingMixin(Ljava/util/List;Lnet/minecraft/class_1799;Lnet/minecraft/class_1937;Lnet/minecraft/class_1309;)Ljava/util/List; -> Prepare]
	at org.spongepowered.asm.mixin.injection.code.Injector.findTargetNodes(Injector.java:305)
	at org.spongepowered.asm.mixin.injection.code.Injector.find(Injector.java:240)
	at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.prepare(InjectionInfo.java:421)
	at org.spongepowered.asm.mixin.transformer.MixinTargetContext.prepareInjections(MixinTargetContext.java:1338)
	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.prepareInjections(MixinApplicatorStandard.java:1043)
	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyMixin(MixinApplicatorStandard.java:393)
	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.apply(MixinApplicatorStandard.java:325)
	at org.spongepowered.asm.mixin.transformer.TargetClassContext.apply(TargetClassContext.java:421)
	at org.spongepowered.asm.mixin.transformer.TargetClassContext.applyMixins(TargetClassContext.java:403)
	at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:363)
	at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:234)
	at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClassBytes(MixinTransformer.java:202)
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:414)
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:323)
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:218)
	at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:145)
	at java.base/java.lang.ClassLoader.loadClass(Unknown Source)
	at net.minecraft.class_2378.method_10234(class_2378.java:192)
	at net.minecraft.class_2378.method_40280(class_2378.java:352)
	at net.minecraft.class_2378.method_34031(class_2378.java:300)
	at java.base/java.util.LinkedHashMap.forEach(Unknown Source)
	at net.minecraft.class_2378.<clinit>(class_2378.java:299)
	at net.minecraft.class_2966.method_12851(class_2966.java:49)
	at net.minecraft.client.main.Main.main(Main.java:153)
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:461)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)

Mod list

- blue_endless_jankson 1.2.1 via jankson
- cloth-basic-math 0.6.0 via cloth-config
- cloth-client-events-v0 3.2.64 via davespotioneering
- cloth-config 6.2.57
- davespotioneering fabric-1.18.2-1.0.9
- fabric-api 0.67.1+1.18.2
- fabric-api-base 0.4.5+64b7c69360 via fabric-api
- fabric-api-lookup-api-v1 1.6.3+2373a54560 via fabric-api
- fabric-biome-api-v1 8.0.6+651bcc5960 via fabric-api
- fabric-block-api-v1 1.0.0+ee3621fc60 via fabric-api
- fabric-blockrenderlayer-v1 1.1.13+3ac43d9560 via fabric-api
- fabric-command-api-v1 1.1.10+d7c144a860 via fabric-api
- fabric-commands-v0 0.2.9+b4f4f6cd60 via fabric-api
- fabric-containers-v0 0.1.24+d7c144a860 via fabric-api
- fabric-content-registries-v0 3.1.2+c85f2e3860 via fabric-api
- fabric-convention-tags-v1 1.0.2+474e4f7960 via fabric-api
- fabric-crash-report-info-v1 0.2.1+ee261a3e60 via fabric-api
- fabric-data-generation-api-v1 3.0.3+9fcb91d260 via fabric-api
- fabric-dimensions-v1 2.1.21+489d6f8260 via fabric-api
- fabric-entity-events-v1 1.4.9+d7c144a860 via fabric-api
- fabric-events-interaction-v0 0.4.20+d7c144a860 via fabric-api
- fabric-events-lifecycle-v0 0.2.21+d7c144a860 via fabric-api
- fabric-game-rule-api-v1 1.0.13+d7c144a860 via fabric-api
- fabric-item-api-v1 1.6.1+a6f01b2660 via fabric-api
- fabric-item-groups-v0 0.3.15+91896a4960 via fabric-api
- fabric-key-binding-api-v1 1.0.12+54e5b2ec60 via fabric-api
- fabric-keybindings-v0 0.2.10+b4f4f6cd60 via fabric-api
- fabric-lifecycle-events-v1 2.1.1+cc71601c60 via fabric-api
- fabric-loot-api-v2 1.1.1+1997ad1260 via fabric-api
- fabric-loot-tables-v1 1.1.3+e747827960 via fabric-api
- fabric-mining-level-api-v1 2.1.5+cc71601c60 via fabric-api
- fabric-models-v0 0.3.7+d7c144a860 via fabric-api
- fabric-networking-api-v1 1.0.24+2d30af4b60 via fabric-api
- fabric-networking-v0 0.3.11+b4f4f6cd60 via fabric-api
- fabric-object-builder-api-v1 2.1.4+032c981d60 via fabric-api
- fabric-particles-v1 0.2.13+526dc1ac60 via fabric-api
- fabric-registry-sync-v0 0.9.12+bb2e047760 via fabric-api
- fabric-renderer-api-v1 0.4.16+ee3621fc60 via fabric-api
- fabric-renderer-indigo 0.5.6+41a02c8a60 via fabric-api
- fabric-renderer-registries-v1 3.2.12+b4f4f6cd60 via fabric-api
- fabric-rendering-data-attachment-v1 0.3.9+ee3621fc60 via fabric-api
- fabric-rendering-fluids-v1 2.0.3+54e5b2ec60 via fabric-api
- fabric-rendering-v0 1.1.14+b4f4f6cd60 via fabric-api
- fabric-rendering-v1 1.10.8+54e5b2ec60 via fabric-api
- fabric-resource-conditions-api-v1 2.0.3+91b7aa6660 via fabric-api
- fabric-resource-loader-v0 0.5.2+446e059560 via fabric-api
- fabric-screen-api-v1 1.0.11+d882b91560 via fabric-api
- fabric-screen-handler-api-v1 1.2.3+1f6558e860 via fabric-api
- fabric-textures-v0 1.0.13+3ac43d9560 via fabric-api
- fabric-transfer-api-v1 1.6.4+f4563ac860 via fabric-api
- fabric-transitive-access-wideners-v1 1.1.0+e747827960 via fabric-api
- fabricloader 0.14.10
- jankson 4.0.0+j1.2.0 via libgui
- java 19
- levelz 1.3.4
- libgui 5.3.0+1.18 via levelz
- libninepatch 1.1.0 via libgui
- minecraft 1.18.2
- mixin-conflict-helper 1.2.0

Game info

Minecraft Version: 1.18.2
Fabric Loader Version: 0.14.10

Message autogenerated using MixinConflictHelper

Log:
latest.txt

Items is invisible

All Umbrellas is invisible

Forge 43.2.7
minecraft 1.19.2
Dave's Potioneering 0.10 - Forge 1.19.2

Recipes do not appear on creative menu or Just Enough Items

Fabric Loader 0.14.25

Mod version fabric-1.20.1-1
JEI version Beta 15.2.0.27 for Fabric 1.20.1

[Suggestion] Add Milk Tag to DP Milk bottles

could you add a #forge:milk tag to the milk bottles from this mod?
That way it will be compatible with other mods, such as Farmer's Delight.

Redistribution

Do modpack authors have the right to redistribute this mod as an override jar, i.e. in Modrinth modpacks? Alternatively, would you like to release on Modrinth or GitHub?

Additional context: Curseforge does not allow downloading mods from curseforge for modrinth modpacks. So when your mod is not available for download elsewhere, the only option is to redistribute the mod's .jar file inside the modpack and move the files to the mods directory. Manually moving files like this in a modpack is called overriding.

[Forge 1.20.1] A couple of items aren't localized (at least in US English)

The Milk Arrow:

And the Magic Lectern (seems like it's still WIP though? Figured I'd add it just in case):

Not sure if the same applies to other languages though.

[1.19.2] Crashes on Startup on Quilt, possible incompatibility with Moonlight Lib

Crash Report:
https://pastebin.com/e07AL7j1

Incompatibility with FancyMenu and Optifine

After selectively disabling certain mods at a time, I found that the combination of the 2 mods (3 including libraries) below causes a crash, near the end of loading. I also tried adding OptiForge, in hopes that it would fix the crash, but it does not.
All mods are the latest version compatible with 1.16.5 as of this time.

Game Log

https://gist.github.com/JawboTau/288c145f334ede8d33b7c163555195d4

Mods

Basic Info

OS: Windows 10
Forge Version 36.3.34
Minecraft Version 1.16.5

Not being updated on Modrinth

This mod has only been receiving updates on CurseForge. Just wanted to let you know that there haven't been any releases on Modrinth in a while.

https://modrinth.com/mod/daves-potioneering

Use fabric-api instead of fabric mod ID for Fabric API

Users may be confused when they see that it depends on fabric, not knowing that it's referring to Fabric API.

As of Minecraft 1.19.2, Fabric API's mod ID has changed from fabric to fabric-api. When backporting from 1.19.2 to earlier versions, you must alter the depends section of your fabric.mod.json to expect fabric.

From https://fabricmc.net/wiki/tutorial:setup#mod_setup. Fabric API still provides the fabric mod ID for compatibility, but it's good to use the new ID where possible.

Line to change:
https://github.com/Tfarcenim/Daves-Potioneering/blob/1.20.1-multiloader/fabric/src/main/resources/fabric.mod.json#L40

Requiem Enchantment Book crashes Game

Rendering the Humanity Enchantment Book Item from Requiem in your Inventory and Containers, crashes the game.
I wasn't sure if I should go here or to the Requiem Github, let me know if I should go over there instead. :)

Here's the Crash Log:
https://mclo.gs/oeOiztE

Item Render Crash

Hi!
Ver Forge 1.16.5
Happens when opening the creative tab or searching in jei.

crash-2022-10-16_23.28.27-client.txt

Thanks! really neat mod btw!

[Bug] Crash when hopper tries transfering with brewing stand

Steps

Place a Compound Brewing Stand.
Place a hopper under it or pointing it.
Crash.
The world keeps crashing when entered.

Versions

MC	Forge	Daves-Potioneering
1.20.1	47.1.44	1.20.1-9

Logs

crash-2024-01-29_12.59.47-server.txt
latest.log
crash-2024-01-31_13.51.39-server.txt
latest.log

Reinforced Cauldron is missing some lang entries

Forge, 1.19.2-1.2

Missing summary description:

Jade has problems showing the name of the block:

Possible incompatibility with Charm

Tried the newest build, keep getting a crash that mentions charm.
latest.log

[Forge-1.18.2] Several Mods Crash When Installing Dave's Potioneering

When downloading this mod and playing it, I noticed a lot of mods crashed on start up. Geckolib is installed, and I have the latest version of Forge.

Crash Report: https://paste.gg/p/anonymous/9c06476a82094a97bfc71bff7c3bc54e

Latest.log: https://paste.gg/p/anonymous/7f42ec832c9e4a55949e464d3ad9d831

Unable to start game

Basically what the title says.
Im using 1.16.5, Mod Version 0.5

Im not getting any crashlogs so here's the latest log:
https://gist.github.com/Asveste/0962ed306d8a745cb31f4f679a24e3c4

Game crashes in 1.19.2 fabric

I created a custom resource for custom named elytras, but when i go to name them. The game crashes with this crash log.
crash-2023-06-25_02.30.08-client.txt

Can i get some assistance? The issue is fixed when Dave's potioneering is disabled.

Incompatibility with Legendary Tooltips

Hello,

Dave's Potioneering seems to be nice, but unfortunately it seems to break an another basic mod (but that is so cool) Legendary Tooltips (Fabric).

I do not know why, but with Dave's Potioneering installed, the outlines of tooltips is just... black or totaly removed like the image below :

It's very strange because if I'm in the search tab in Creative mode the issue is done and everything works well :

[SUGGESTION] Spiking food with various potion effects

There are several mods like this for Forge, but none for Fabric. This ability would fit well here.

Add geckolib dependency to fabric.mod.json

Some users download this mod from the Modrinth or CurseForge websites without checking for dependencies. Without GeckoLib, it results in a crash which users find difficult to understand. Putting the GeckoLib dependency in the FMJ results in the Fabric Loader mod resolver window which communicates the dependency outside of Modrinth and CurseForge.

Where to add this: https://github.com/Tfarcenim/Daves-Potioneering/blob/1.20.1-multiloader/fabric/src/main/resources/fabric.mod.json#L38

[Fabric 1.20.1] Shift-Clicking bottles into slots causes an entire stack to be inserted

As the title says, when shift-clicking bottles into slots for a brewing stand, either vanilla or modded ones, a whole stack will be inserted when it normally shouldn't. Because of this, if you continue to brew with the stacks in the slots they will be corrected after the brew is complete, causing you to permanently lose any extras, meaning 15 per slot in a stand. The compound stand doesn't lose them, but the limit seems to have been two potions per slot when adding them normally, so this likely isn't intended behavior.

A video demonstrating the issue:

8mb.video-amA-K76DoGWq.mp4

[Forge 1.19.2] Crash on JEI

The problem is with the Gekolib item animation render. Something similar happened last week with Ars Nouveau.
Dave's Potioneering 1.19.2-1.0.1 - may have caused crash
Just Enough Items 11.4.0.274 - may have caused crash
GeckoLib 3.1.32

https://crashy.net/S8lmPbR7WF0M5cpXMOs6

A crash with mod Corail's Tombstone

Hello，Tfarcenim！I found Daves-Potioneering will have a crash when it worked with Corail's Tombstone mod in 1.16.5!It made me have to choose one between them!But I dont want to do that!Will you try to compatible your mod with it?Its really important for me!Please reply to me no matter what you want to do!Thank you!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

1.20.1 - config includes both coat_anything and coat_all

In tfar.davespotioneering.ModConfig.Server, the 'coat_all' variable is assigned twice, first as:
coat_all = builder.define("coat_anything",false);
then as:
coat_all = builder.comment("Allows all items to be coated").define("coat_all",false);

This causes the configuration to have a "coat_anything" value that can be assigned but will be ignored and has no translation key. Meanwhile the "coat_all" value is what is used.

It appears that the first assignment referencing "coat_anything" should be removed.