tgallant / embedd Goto Github PK

Hi

Please try out the demo URL https://embedd.io/try-it-out/?url=https%3A%2F%2Fwww.example.com%2F&limit=5&loadMore=true&infiniteScroll=false&dark=false&both=true&service=reddit

It produces some strange results about politics. When following the links, the target thread is on an unrelated domain.

This repo needs maintenance
throws error when response.data return an array in dataFmt (reddit)

embeddSpec.dataFmt = (response, cb) => {
  if (!response.data && Array.isArray(response)) {
    response = response[0];
  }
  [...]

Hi, from today something changes in reddit api, and everything stopped working.
Embedd is currently calling:

https://www.reddit.com/search.json?q=url:http://blog.codeisc.com/2017/12/26/cpp-comma-operator-introduction.html

and it doesn't find anything. BUT if you remove the url:, it works:

https://www.reddit.com/search.json?q=http://blog.codeisc.com/2017/12/26/cpp-comma-operator-introduction.html

not sure if this is a reddit bug or embeddd

Not able to capture any comments from Reddit even though the thread exists,
Ref: https://www.reddit.com/r/netsec/comments/81df7k/the_infamous_vulnerability_of_target_blank_code/

Strange is the same things works well when I integrate the Cloudflare app "Embeddit". Do you have different scripts supplied to Cloudflare vs. hosted here?

Is there any way to have a snippet or javascript method which return an url to post comment on a service?
Something like:

<script src="embedd.js">
    {
        "url": "https://www.eff.org/deeplinks/2015/10/closing-loopholes-europes-net-neutrality-compromise",
        "add_comment_link": ["hn", "reddit"],
        "debug": true
    } 
</script>

Or any other way to add it.
And maybe another message when url is not found on a service, like, "Post this article on Hacker News to comment".

new embedd version doesn't work at all:
check http://blog.codeisc.com/2018/01/09/cpp-comma-operator-nice-usages.html

IMHO, it should give an option to -> share at Reddit when there are no comments, rather it throws the JS error,

embedd.min.js:1 Uncaught (in promise) Error: Callback was already called.
    at embedd.min.js:1
    at <anonymous>
(anonymous) @ embedd.min.js:1
Promise.catch (async)
t @ embedd.min.js:1
(anonymous) @ embedd.min.js:1
n @ embedd.min.js:1
wr @ embedd.min.js:1
a.hasComments @ embedd.min.js:1
(anonymous) @ embedd.min.js:1
i @ embedd.min.js:1
(anonymous) @ embedd.min.js:1
N @ embedd.min.js:1
(anonymous) @ embedd.min.js:1
Pe @ embedd.min.js:1
We @ embedd.min.js:1
h.init @ embedd.min.js:1
(anonymous) @ embedd.min.js:1
t @ embedd.min.js:1
(anonymous) @ embedd.min.js:1
(anonymous) @ embedd.min.js:1

Strange is the same thing works well, when I integrate the Cloudflare app "Embeddit". Do you have different scripts supplied to Cloudflare vs. hosted here?

I believe adding the following tags to the provided <script> tag could offer some end-user benefits

• defer
  Adding comments shouldn't hold a higher priority over any other page content

• crossorigin="anonymous"
  Prevents embedd.io from eavesdropping on the page content

use 2.0 workflow and update to node 10.13.0

It looks like our website https://clickhouse.tech/blog/en/ is using your script to embed comments from Hacker's News.
It leads to possible XSS and broken HTML markdown.

Hi, after the changes reddit keeps failing.

https://embedd.io/try-it-out/?url=http%3A%2F%2Fblog.codeisc.com%2F2018%2F01%2F09%2Fcpp-comma-operator-nice-usages.html&limit=5&loadMore=true&infiniteScroll=false&dark=false&both=true&service=reddit

this is very strange, looks like a real bug in reddit's API

Line 15 in "templates/comment.html" should read:
{{#permalink}}<span><a href="{{permalink}} target="_blank"">{{subreddit}}</a></span>{{/permalink}}
Also, the links in the comment bodies (actual comment texts) should have a target="_blank"-attribute but I'm not so sure how to do that (using mustache?).

Cheers :)