Giter VIP home page Giter VIP logo

angularjs-heroes-laravel's Introduction

Olá, seja bem-vindo! 👋

Meu nome é Thiago, sou um desenvolvedor front-end apaixonado em criar e manter aplicações seguindo boas práticas afim de garantir uma boa experiência tanto aos usuários quanto aos outros desenvolvedores. Além de conhecimento de front-end, possuo também conhecimentos de back-end (node, express, prisma ORM...) e UX/UI design (figma). Meu objetivo é entrar no mercado de trabalho como desenvolvedor front-end ou fullstack júnior. Conheça algum de meus trabalhos através do meu portfólio.

Entre em contato

tecnologias que possuo experiência:

Tecnologias que estou me especializando


angularjs-heroes-laravel's People

Contributors

th-fernandes avatar

Watchers

 avatar

angularjs-heroes-laravel's Issues

Bug | Apply button does not work anymore

Description

After the big refactoring where we imigrated all of the front-end logic into our brand new Laravel back-end, some previously functional pieces of code are no longer working. Some of that parts refers to the apply to opportunity feature that consists in user making a PATCH request on the given opportunity model. The issue is that all the logic behind this behavior just does not exists anymore. Hence, when user clicks on 'apply' button nothing happens

Step-by-step

  • sign in to the app
  • go to #!/opportunities route
  • click on 'apply' button and observe that nothing happens

Suggestions

In my opinion, the best approach is to consolidate all the PATCH request logic within the update method in Opportunities HTTP controller. The front-end's role will then be limited to triggering the endpoint responsible for making the request.

Bug | Header does not change its sign action button

Description

It's been a while since we've implemented the new login / user session features using laravel resources to achieve the desired results, and it fits our needs. However, it introduced a new error in our main layout: instead of display 'sign out'' while the user is logged in, it still shows 'sign in' . Additionally , it does not change the sign action, in fact, it only has the ability to sign in, causing it to redirect the user to /#!/heroes instead of signing them off.

Step-by-step

  • sign in to the app
  • observe that 'sign in' button still displays sign-in instead of 'sign out'
  • click on the sign in button and observe that you are going to be redirected to /#!/heroes and still being logged in

Sugestions

As I have seen, the header responsible for this behavior is on the app.blade.php server view. We should, in my opinion, move set the header apart this file and set is a angular component so we can both reuse it on the server view and define its controller logic. We need to somehow create or trigger an endpoint to sign out the user and wrap it into a angular service so we can observe whether the request failed or not, if it fails throws it to the user and persist his signing but if succeed whe redirect user to #!/heroes but now signed-out.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.