Compatibility with BeautyQuests about ouroborosmines HOT 10 CLOSED

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.80. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

from ouroborosmines.

Alright, a first version of the BeautyQuests support is implemented in the current dev build, I've posted on Discord. At the moment it uses reflection to update the quests progress as you can see in 2354cba.

from ouroborosmines.

Hey! I'm the dev of BeautyQuests. It seems like this issue is caused by the cancelling of the BlockBreakEvent.

from ouroborosmines.

And does that mean I have to report it to them or what? Sorry but I do not understand.

from ouroborosmines.

And does that mean I have to report it to them or what? Sorry but I do not understand.

No no, it's just so that the dev knows what's the issue ^^

from ouroborosmines.

Hey everyone 🙂,
it is as SkytAsul said, OM takes the control over the blocks by cancelling the BlockBreakEvent.
This is the expected behaviour. In case of Quests, OM simply adds progress to the Quests, when the objective contains the mined material. I'd really like to add a similar way of support for BeautyQuests. However, I haven't completly understood the way to update the quest progress yet.

Maybe you can give me a hint @SkytAsul ^^

I'm looking forward to hearing from you 🙂

from ouroborosmines.

Again, thank you very much.
I hope this helps everyone.

from ouroborosmines.

Oh well that's a good solution ^^ I will make the "event" method public so that reflection is no longer needed. See my PR, I optimized the code a bit and removed extra useless things here and there!

from ouroborosmines.

Thank you for the PR! I'll have a look at it asap! 😃
Making the event method public will make it much easier and cleaner for me!

from ouroborosmines.

I merged #41 into the feature branch.
Testing results look good so far 👍🏼
@Italoplcl Let me know when you're done with testing, so I can provide you with a new test build 🙂

from ouroborosmines.