thampe / inky Goto Github PK

Thanks for making this, it's looking very useful. Do you have any plans to integrate Inky's inliner functionality? Or have I missed that somewhere?

when using , the attribute 'valign' is not reported on dist, although it's working on the last release of inky.

That valign property is essential for outlokk clients, for instance.

Hiya, I'm encountering an issue after upgrading from 1.3.5.0 to 1.3.6.0.

Given the following partial markup, the spacer element on the inside of the table does not get parsed, while the ones on the outside do:

<container>
    <wrapper>
        <row>
            <columns small="12" large="12">

                <spacer size="40"></spacer>

                <table>
                    <tr>
                        <th>
                            <spacer size="220"></spacer>
                        </th>
                    </tr>
                </table>

                <spacer size="40"></spacer>

            </columns>
        </row>        
    </wrapper>
</container>

I am using Simple layout from Foundation email templates and the word "Simple" in the header is not aligned right as it should be. The table which it is in doesn't have 100% width. The problem may have something to do with the fact that expander is not generated inside the inner table?

<style> tags are being stripped out when I use this, I'd like to keep them so I can later inline the CSS. I briefly looked into it and I think it's an issue with PHPHtmlParser.

I'm working on a package for Laravel to use this nicely (https://github.com/petecoop/laravel-inky), really thankful you've built a PHP parser for inky!

Would be great to allow XML-namespaced inky tags for integration with templating engines and CMS. Some templating engines like TYPO3.Fluid or phptal are XML-based. Using namespaces would ease both validation and separation, e.g. <inky:container> etc.
I‘m aware of reaching beyond Foundation for Emails compatibility and that this can be resolved with either subclassing or using component factories as well. So this is more like a poll if there are people around interested in improved XML support.

Hi there!

I was wondering if there are plans / progress in implementing the changes of Inky 1.3.6 to this library. I would like to help but it would be good to know if some parts are already developed.

https://github.com/zurb/inky/releases/tag/v1.3.6

Thanks!

Today I found out that the compilation is qutie slow for rather large email. I have an email layout with some Inky template elements and inside the content block of layout is one large table (1000 rows) that itself does not contain any Inky special elements. The comilation of one such e-mail takes 150 seconds. It means that it is 0.15 s per one row in the e-mail, that is VERY slow.

Tags such as pre that requires white space and line breaks to maintain formatting are compressed during template compilation, rendering data in pre tags unreadable.

This appears to be related to $dom->setOptions in Inky.php (line 187), as the Dom object does not preserve line breaks by default. Updating the call to include 'preserveLineBreaks' => true, in the options fixes this, but I'm not sure if setting this globally is the best approach.

I'm happy to open a pull request, I just wanted to see if there was feedback on if this is the route to go.

The library truncate the HTML when it is malformed:

$inky = new \Hampe\Inky\Inky();
echo $inky->releaseTheKraken('<p>Malformed HTML</a></p><p>Next paragraph</p>');

This exemple will return:

<p>Malformed HTML</p>

Is it far behind https://github.com/zurb/inky ?