thanpa / buckaroo-php-sdk Goto Github PK

Hi there,

FIrst of all; thanks for creating this SDK. It saved me some time figuring out the Buckaroo API.

I tried creating an iDeal payment with action "Pay" without adding an issuer to the service which resulted in this error:

PHP Fatal error:  Uncaught Buckaroo\Exceptions\UndefinedIssuerForServicePayActionException in vendor/thanpa/buckaroo-php-sdk/src/Validators/ServiceValidator.php:41

The documentation of the Buckaroo API states the following about the issuer parameter (https://dev.buckaroo.nl/PaymentMethods/Description/ideal):

BIC code of the issuing bank of the consumer. Please refer to the list of banks in the general section for the list of BIC codes. This information is required, but it is possible to let the customer fill it in on the Buckaroo checkout page. In that case, leave the Issuer parameter out and add the basic parameter "ContinueOnIncomplete" with a value of 1.

I will add a "Select your bank" select in my checkout for now, but perhaps it would be nice to implement the possibility to create iDeal payments without an issuer.

Best regards,

Peter ten Hoor

Implement a get method in the buckaroo master class to retrieve a transaction by the key

This issue is closed because it was implemented in ISSUE #15

Add validator classes for:
Url (done)
Service (reflection) (done)
Currency (done)
RequestInformation: type (done)
Transaction: mutation type, continue on incomplete (done)

Validation for method. When method is pay, validation for issuer and issuing bank value. When method is refund, validation for OriginalTransaction.