thatlittleboy / lgtm-db Goto Github PK

Right now, release is still largely a manual process (need to commit a release commit, and tag, etc.).
There is a chance to automate it using some task runner.

Don't really want to use Make, can try some python-based alternatives like doit or just.

• default with no args should print help message
• selecting random gifs like lgtm-db random ?
• selecting a random gif based on name / tag etc.
• list (names of) all available gifs

From #11 , I added in a script to scrape the image height and width from the source URL, and write it back into the db.yaml file.

There are a few possible improvements:

1. Use async / await instead of sequentially calling. [DONE]
2. Incorporate the use of this script as a test (unconfirmed, since this might slow down tests ALOT) to make sure width/height is always provided, and is up-to-date with the image on the source URL.
3. Currently script is writing to new_db.yaml; it should overwrite db.yaml?

db.yaml should support tags so we can also select random gif based on tags.

Such as:

• (Type)
  • nice / good work / thumbs up
  • approve
  • merge / ship-it
• (Subject)
  • animal
  • human

etc.

Right now, there are no proper checks on the validity of the additions to db.yaml.

• if there are duplicated names (id's should be unique)
• if there are duplicated urls
• if there is width/height information

etc.

I think we can write some local pre-commit hooks or just rely on CI (shell script checks). Either is fine.

Take the leap into adding type hints into the code base.

Upgrade the minimum python version to 3.9 if necessary. Add mypy to precommit.

Not sure if this is a testable thing, but I want to think the argparsing functionality of the CLI app needs to be tested.
Can double check against popular tools like flake8, pre-commit or black to see how they test.

• Initialize pytest framework
• Add tests for Matcher (introduced in #37)
• Add tests for GifLoader (introduced in #37)
• Run tests on CI/CD

Just added in tests in #45 , I should add relevant badges to the README

follow

• https://github.com/charliermarsh/ruff/blob/main/ruff_dev/src/utils.rs
• https://github.com/charliermarsh/ruff/blob/eda2be635062c37dfaaccb630d2510cf458f8dd6/README.md?plain=1#L362
• https://github.com/charliermarsh/ruff/blob/main/.github/workflows/ci.yaml#L30

Write a python script to do something similar. Run diff in github workflow to detect when README is out of sync with the cli.

i.fluffy.cc seems to be blocked by uBlock origin, perhaps I should collate the gifs all on giphy.

(img being tested here is the multiple pikachu one)

Check work vn-consolidation merge request 13 to test.