.finally called twice when .maybe rejects all promise followed by else about flowerflip HOT 5 CLOSED

In fact this seems to be generalize when two NegativeResults promises follow each other.

from flowerflip.

https://trello.com/c/frnYEXdW/2241-flowerflip-differentiate-positive-negative-destination-2

from flowerflip.

This is just to clarify my understanding of the problem:

if choice.type in ['always', 'finally'] and source.type in PositiveResults
        gotPositive = true
        break if gotNegative
if choice.type is ['always', 'finally'] and source.type in NegativeResults
        gotNegative = true
        break if gotPositive

In my example, both .else and .maybe will be registered as sources for the finally. And since finally is in both Negative & Positive when maybe is rejected it will look in its Destinations by callind findDestinations it will get both else and finally.

from flowerflip.

Yep. And we need to distinguish whether we're registering for negative or positive result

from flowerflip.

I have produced a failing test for this one, will try to fix early tomorrow

from flowerflip.