Eating items in .all about flowerflip HOT 8 CLOSED

@bergie, I thought we fixed this issue by attaching eaten content to the nodes? Subtrees will likely eat an item or a block, not being able to use such subtree in an all is a very strange limitation. Taylor is doing this now...

If this limitation is to remain, we will likely need another all composite promise that is synchronous.

from flowerflip.

@d4tocchini we do attach them, but only after the sub-promises resolve. Since JS is single-threaded, this would in effect makes the promises in .all run serially, not in parallel. So, in that sense it probably works.

from flowerflip.

Hmm... I think it actually works, but we'd need a test to prove it

from flowerflip.

I added a (failing) spec for this in 322cd06.

from flowerflip.

@cbchouinard: another docs update needed here.

from flowerflip.

Note: this only works as long as the tasks given to all are synchronous

from flowerflip.

@bergie: could you clarify? I'm not sure what that translates to in the API.

from flowerflip.

@paulyoung currently we're running every component in flowerflip synchronously, and that allows eating in all to work since one task completes before the next starts. If the tasks were async, they'd all start at the same time, and wouldn't see what the others do. Not a concern for design systems (where everything will be sync), but something to keep in mind.

from flowerflip.