Giter VIP home page Giter VIP logo

Comments (7)

cgomesu avatar cgomesu commented on July 18, 2024 2

new demos are always welcomed, @Jumitti . please read our contributing guidelines first. you can use the other demos as a template but feel free to go beyond if your implementation requires slightly more complex code. when you're ready, just submit a PR to the main branch (add -fix #68 to the description to link it to this issue) and this will start the formal review process.

from lcd.

cgomesu avatar cgomesu commented on July 18, 2024 1

from lcd.

cgomesu avatar cgomesu commented on July 18, 2024 1

that looks good. loved the in-depth documentation. if I may suggest you a couple of things:

I think it would look better your repo focused just on your implementation. that is, remove all the other demos and unrelated files (.github, CONTRIBUTING.md, edit the About, etc) and remove the demo_ prefix from your scripts because I think it's more than just a demo.

once you are done with all that, ping me here and I'll edit the README.md to reference your implementation. (happy holidays to you too!)

from lcd.

Jumitti avatar Jumitti commented on July 18, 2024

Hello @cgomesu

So I use API for my script. So it requires tokens and IDs for connections. I usually use a SECRETS.json to store this information and not have it written directly in the script. It’s security.

But over time, I got into the habit of putting all the script variables in there. This allows certain parameters to be modified quickly without stopping my scripts.

Do you think I should do the same for the LCD? I don't know if it will be user friendly enough

from lcd.

Jumitti avatar Jumitti commented on July 18, 2024

Hello @cgomesu

Sorry to bother you again during the holiday season.

I think I'm done with my scripts and documentation. If you have a moment or the desire, take a look at my Github repo https://github.com/Jumitti/lcd_home_automation
I actually think that the simplest thing would be to just put a reference in the documentation of the official repo, as you suggested yes.
If you find anything missing, let me know.

Happy Christmas and Happy New Year

JM

from lcd.

Jumitti avatar Jumitti commented on July 18, 2024

Hello @cgomesu

I think I'm done with the documentation etc of Home Automation. If you see anything else, don't hesitate to tell me.

I also created a small Streamlit application (web deployment of a python script) to facilitate the creation of custom characters. I didn't do a fork for that, here is the Github https://github.com/Jumitti/lcd_custom_characters and the Streamlit application https://custom-characters-for-lcd16x2.streamlit.app/
I think maybe this might interest people, maybe

Best,

Julien

from lcd.

cgomesu avatar cgomesu commented on July 18, 2024

awesome! I`ll push a change in the documentation to reference your implementations asap.

from lcd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.