Giter VIP home page Giter VIP logo

pirates-online-classic's Introduction

Pirates Online Classic

This is the game development repository for Pirates Online Classic, a fan-made recreation of Disney's now-defunct MMORPG; Pirates of the Caribbean Online.

forthebadge forthebadge forthebadge

Merging

All merges should go through a three-step process:

1. PR goes up by creator when the changes are ready
2. PR is reviewed by another person
3. PR is reviewed and merged by a third person

For emergency/security merges, only steps 1/2 are required if time is an issue.

Verification Guidelines

Eventually we'll begin working on the verification codebase; when this happens we need to follow a set of regulations:

  • Don't update deprecations, the goal(currently) is to make it as close to the original as possible.

  • If you find code on the client you deem "Unnecessary" don't remove it, don't touch it; If it isn't broken, don't fix it.

  • Custom client features that poc previously had(e.g Rich Presence, Various discord integrations, Userfunnel modifications, etc, etc) should not be added back until the codebase is nearing beta release ready.

  • Retain originality. In the process of developing on this branch, we may need to alter things to support astron and the csm, we should try to retain as much originality as possible and not modify it out of the scope it needs to make certain things function.

  • Do not run autopep formatters or any kind of formatters on the codebase, it's been manually formatted.

If you have anymore questions, ask me.

Branches

Master

Master is a branch that's stable, you're not to commit directly to master.

Develop

Develop is a branch that is used for development purposes, namely it's purpose is for experimental changes and new features, which then get branched off to the QA branch for internal testing. Most temporary developmental branches should be based off this branch.

QA

QA is a branch that the internal testing server resides on, it's used to push W.I.P features/functionalities and have internal testers test them.

Verify

The verify branch houses the W.I.P client verification, which to put it in layman terms is a W.I.P complete redecompilation of the client intending to correct every mismatch from the original bytecode to our decompiled source code.

Commit Guidelines

  • Do NOT modify the client to benefit the server, we're creating a server for the client, not a client for the server.

  • Please keep your code clean, do not leave extraneous whitespace and use spaces not tabs.

  • Give information on your commits, such as pirates/piratesbase: fix a grammar issue with the localizer.

  • Give commit descriptions when plausible.

  • If you're writing a new feature or doing any substantial change, please push it to a seperate branch and make a pull request when you believe it's ready. Refer to the Merging and Branches section for more.

Requirements

Other

License

Pirates Online Classic is licensed under the "BSD 3-Clause" for more information, refer to LICENSE file.

pirates-online-classic's People

Contributors

cmarshall108 avatar thetestgame avatar theclashingfritz avatar chillymike avatar armatech2000 avatar

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.