theansarya / bps-patch Goto Github PK

I needed BPS decoder so I looked at your code for guidance. I needed to completely re-write it however to support Unity3D for my project as I don't access to any of these interfaces you are using but I did notice these two lines in your code. I don't have access to Slice() and AsSpan() in Unity or how they work exactly, I just access the buffers directly in my code but I think the second source.Read() should be without the "(int)target.Position +" like the patch.Read() above. I think you are just creating a much larger than necessary read only copy of the buffer with the Slice() operator in the second instance although I don't really understand these function precisely. Anyways I thought I would point it out at let you decide if there is anything to my findings.

				**patch.Read(targetData.AsSpan().Slice((int)target.Position, length));**
				target.Position += length;
			} else {
				int offset = (int)decodePatch();
				offset = ((offset & 1) != 0) ? -(offset >> 1) : (offset >> 1);
				if (mode == PatchAction.SourceCopy) {
					// Copy from another part of the source file
					sourceRelativeOffset += offset;
					source.Position = sourceRelativeOffset;
					**source.Read(targetData.AsSpan().Slice((int)target.Position, (int)target.Position + length));**