theglenn / flipper-android-no-op Goto Github PK

Duplicate class leakcanary.LeakCanary found in modules jetified-flipperandroidnoop-0.10.0-runtime (com.github.theGlenn.flipper-android-no-op:flipperandroidnoop:0.10.0) and jetified-leakcanary-android-core-2.9.1-runtime (com.squareup.leakcanary:leakcanary-android-core:2.9.1)

Please include all your classes within a package only. so to resolve leak-canary duplicate classes.

First of all, thank you for publishing this library! I'm not sure why FB doesn't just include everything in their own no-op package, but there you go. 🙇

I want to use this at work but I ran into an issue, which is that because we're using another FB library which also includes SoLoader, I get a build failure due to conflicting implementations. Would you be open to publishing separate artifacts? We could even keep the existing package as-is and add another:

  // add this to no-op Flipper + SoLoader
  releaseImplementation 'com.github.theGlenn:flipper-android-no-op:0.3.0'

  // add this to no-op only Flipper
  releaseImplementation 'com.github.theGlenn:flipper-only-android-no-op:0.3.0'

There are any plans to add support to UIDebuggerFlipperPlugin?

Hi @theGlenn , the last release is unfortunately not working

e: /home/jitpack/build/flipperandroidnoop/src/main/java/com/facebook/flipper/plugins/databases/DatabasesFlipperPlugin.kt: (14, 5): 'onConnect' overrides nothing
e: /home/jitpack/build/flipperandroidnoop/src/main/java/com/facebook/flipper/plugins/databases/DatabasesFlipperPlugin.kt: (17, 5): 'onDisconnect' overrides nothing
e: /home/jitpack/build/flipperandroidnoop/src/main/java/com/facebook/flipper/plugins/databases/DatabasesFlipperPlugin.kt: (21, 5): 'runInBackground' overrides nothing

FAILURE: Build failed with an exception.

I think there is some mistakes with the 2 PR #13 #12. Maybe @e16din & @kobeumut can take a look?

NB: we have 2 different flipper versions declared
def flipper_version = '0.85.0'
def flipper_version = '0.87.0'
It would be great to harmonize with the same version

Probably related to this jcenter issue.
Here's the jitpack log.

It was resolving fine this morning, but is currently unavailable.

It is why the flipper-android-no-op methods are not static, when I try to change build variants Android studio shows a compile error.

Hi! Thanks again for merging #5 … could you please publish a new version soon so I can start using this? 🙏

Are you open for PRs? I could add stubs for CrashReporter and Navigation plugins