So that it fits other extensions naming

Diagram ->Export: we need to propose a dialog and let the end-user choose a name and a location about the export diagram. Currently, it creates a file under the folder of the selected diagram and create a file with the extension ".svg". This could be the proposed default name for the end-user.

Double-click on a referenced module should show/hide it's contents and references from the surrounding model to it.

Diagram -> Center: Seems the command does different things depending where the last user focus was in the diagram. It seems it center the last module the user selected. No indication on the diagram to show what was the last user selection.

Similar to the Theia/Sprotty example, we need

• a browser application for Yangster
• connects to yang-lsp
• has syntax coloring, bracket matching, etc. for YANG
• allows opening a class diagram on yang files

The hover popup should show the description of the underlying element.

Menu "Selection" available, but all options aregreyed out. Should we have this menu option available?

Some users are requesting the git extension in the app could you add this ? to https://github.com/theia-ide/yangster/blob/master/yangster-app/package.json

same for electron ?

Thanks,

I tried building it and I got a maven error after cloning xtext-jflex. Looking at the other project it seems it recently switched from maven to gradle, so that might explain it.

In navigator view, Context menu :"Open" and context menu " Open With -> Code editor" do the same for a file if we cannot set the default editor to the last editor used for a file.

I.e https://hub.docker.com/r/typefox/yangster/

We should find a way to update this one to the latest master when possible, either by having travis push to docker hub, or having the docker hub triggering a re-build of the image when master changed.

In the diagram view, there is no edition, we cannot move the content to another location within the diagram, it moves the complete diagram.

Double click on a module in the diagram open the text portion for it with the selected piece of the diagram, is it possible to enlarge the selected module only , not necessary open the editor with double click. Open the editor should be on another key.

Enlarge the diagram: we can use the mouse wheel to en-large/reduce the diagram, but can we use the left click on a corner of the diagram and enlarge/reduce it to the end-user preferred size ??

Selecting File -> Open --> open a dialog, then the user can select a file then open: ==> no choice to open the Diagram editor for that file (Can be fixed with the default editor for a file extension)

Select a file in the navigator , then use the keyboard and use the delete button to delete the file ==> nothing happen. (Key binding to the delete button needed"

No vertical/horizontal scroll to see the whole diagram.

Should we have a context menu to adjust the properties of the selected diagram item or a property view?

Try to open the exported diagram with the option "Files -> Open with -> Yang Diagram" ==> open an editor which does not show the diagram at all.

Since Yangster runs in a dark theme, the diagrams should match.

Here are some dark theme based class-diagrams for inspiration:

http://www.thinkboxsoftware.com/kmy-magma-editor/

When opening a diagram , on the console, the "jsonrpc" data structure is displayed, we should put this in a debug level mode, not necessary show it on the console log all the times unless we are in debug mode.

Single quoted strings are colored wrong. Example:

I get:

[2018-02-02T12:10:41.311Z] ERROR: Theia/11950 on elxa4wqvvz1: 07:10:41 widget-0_sprotty Viewer: element not in DOM: [ 'widget-0_sprotty' ]

Ideas ?

Looks like some CSSs are missing

From the workspace navigator, double click on a file open the code version of the selection. If I selected the "Open With -> Yang Diagram" previously, I would expect the second time I open the file to use the "Yang Diagram" and not the code editor. May we can have a preference for "Double Click opening the editor"

I upgraded to yarn 1.0.2, and now the LSP is no longer copied. It's a preinstall task of theia-yang-extension.

• Run theia from the sources (electron or browser)
• install theia-yang-extension using the extension manager
• reload

The screen stays black. On the console I see

index.js:50 Error: Cannot apply @injectable decorator multiple times.
    at injectable.js:8
    at DecorateConstructor (Reflect.ts:1090)
    at Object.decorate (Reflect.ts:284)
    at _decorate (decorator_utils.js:42)
    at Object.decorate (decorator_utils.js:55)
    at Object.defineProperty.value (widget.ts:13)
    at __webpack_require__ (bootstrap 0c054091550f5e565229:688)
    at fn (bootstrap 0c054091550f5e565229:109)
    at Object.m (index.ts:8)
    at __webpack_require__ (bootstrap 0c054091550f5e565229:688)

The target is the class Widget.

Diagram -> Fit-to-screen : Seems the command does different things depending where the last user focus selection was in the diagram. Sometimes, we seem the whole diagram, sometimes, we see only one box within the diagram. It looks like depending the last time you click on the diagram, it enlarge this section of the diagram to fit the screen, but there is no indicator in the diagram showing what is being "selected"

https://github.com/theia-ide/yangster/blob/cd8d38e3024fb41dd77804a1c59089432e27491c/theia-yang-
extension/src/backend/backend-extension.ts#L50
socket.connect(socketPort)

Here in the current implementation, only port is allowed.
I think to support both port and host will be much useful.

Required Socket API
NodeJs Socket.connect API

It would be nice if the diagram reveals and marks what is selected in the editor and vice versa.

Current version of @theia/monaco is '0.3.0-next.218d2c46': '2017-10-30T13:15:50.681Z',.
It should be '0.3.0-next.db76dbf1': '2017-11-02T11:18:13.414Z'.

eclipse-theia/theia#754

If you select the file: "example-3-a.yang" , hover the diagram will open a dialog with the information and the Namespace for the file will be "example-3/a". Why do we replace the last"-a" by "/a" and the end?

What is the purpose of the Copy/CUt/PASTE/ (All Edit menu option) if the diagram is not editable?

Only works when the LSP is started in socket mode.

Exceptions is:

Error while processing build resultsjava.util.concurrent.CompletionException: java.lang.reflect.UndeclaredThrowableException
   at java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:273)
   at java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:280)
   at java.util.concurrent.CompletableFuture.uniAccept(CompletableFuture.java:659)
   at java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:632)
   at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474)
   at java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1962)
   at org.eclipse.xtext.ide.server.concurrent.RequestManager.lambda$null$0(RequestManager.java:78)
   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
   at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
   at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.reflect.UndeclaredThrowableException
   at com.sun.proxy.$Proxy31.notify(Unknown Source)
   at org.eclipse.lsp4j.jsonrpc.services.EndpointProxy.invoke(EndpointProxy.java:74)
   at com.sun.proxy.$Proxy33.accept(Unknown Source)
   at io.typefox.sprotty.server.xtext.DiagramLanguageServerExtension.lambda$initializeDiagramServer$2(DiagramLanguageServerExtension.java:127)
   at io.typefox.sprotty.api.DefaultDiagramServer.dispatch(DefaultDiagramServer.java:111)
   at io.typefox.sprotty.api.DefaultDiagramServer.submitModel(DefaultDiagramServer.java:194)
   at io.typefox.sprotty.api.DefaultDiagramServer.updateModel(DefaultDiagramServer.java:137)
   at io.typefox.sprotty.server.xtext.DiagramLanguageServerExtension.lambda$updateDiagram$11(DiagramLanguageServerExtension.java:228)
   at java.util.concurrent.CompletableFuture.uniAccept(CompletableFuture.java:656)
   ... 8 more
Caused by: java.lang.reflect.InvocationTargetException
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
   at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   at java.lang.reflect.Method.invoke(Method.java:498)
   at org.eclipse.lsp4j.jsonrpc.services.EndpointProxy.invoke(EndpointProxy.java:96)
   ... 17 more
Caused by: org.eclipse.lsp4j.jsonrpc.json.InvalidMessageException: An element of the message has a direct or indirect reference to itself.
   at org.eclipse.lsp4j.jsonrpc.validation.ReflectiveMessageValidator.consume(ReflectiveMessageValidator.java:49)
   at org.eclipse.lsp4j.jsonrpc.RemoteEndpoint.notify(RemoteEndpoint.java:95)
   ... 22 more

Can we get accelerator key for : "Center", "Fit to screen"

In the "Yang Diagram" navigator, double click open the "code editor", but there is other way to open the diagram directly from the navigator and open the "Yarn Diagram" than selecting through the menu selection. There is no accelerator key.

TODOs:

• Currently, the yangster/yangster-app-electron/package.json cannot be used as we do not have a solution for dealing with symlinks with the electron-builder. (Alternatively, we could provide another package.json and use that for the bundling phase.) (See the attached package.json.)
• LS does not start inside the packaged application. The executable path is hard-coded in the the backend extension: ../node_modules/theia-yang-extension/build/yang-language-server/bin/yang-language-server. After the bundling, the module that defines the above mentioned executable path is inside: yangster-electron.app/Contents/Resources/app/node_modules/theia-yang-extension/lib/backend/backend-extension.js. One level up, no node_modules folder exists, hence it cannot work. (Fixed with 7e7e55b)
• Update the yarn.lockso that it can pull the fix for the electron issue in Windows due to the AMD loader. Current version of @theia/monaco is '0.3.0-next.218d2c46': '2017-10-30T13:15:50.681Z',. It should be '0.3.0-next.db76dbf1': '2017-11-02T11:18:13.414Z'. (#43) (Fixed with 687b37f)
• LS does not start on Windows. I guess, we need the .bat file extension when starting the process. (Fixed with 91d1677)
• Nice icons would be great. (#42 (comment))
• One should be able to browse the desired instllation location when using the nsis installer on Windows.

package.json:

{
  "name": "yangster-electron",
  "version": "1.0.0",
  "description": "Yangster Electron",
  "main": "src-gen/frontend/electron-main.js",
  "repository": {
    "type": "git",
    "url": "git+https://github.com/theia-ide/yangster.git"
  },
  "theia": {
    "target": "electron"
  },
  "build": {
    "appId": "yangster-electron.app",
    "productName": "Yangster",
    "files": [
      "src-gen/**/*",
      "lib/**/*",
      "node_modules/**/*",
      "package.json"
    ],
    "directories": {
      "buildResources": "resources"
    },
    "asar": false,
    "publish": null,
    "nsis": {
      "menuCategory": true,
      "oneClick": false,
      "perMachine": true,
      "installerHeaderIcon": "resources/icon.ico",
      "allowToChangeInstallationDirectory": true,
      "runAfterFinish": false
    },
    "mac": {
        "target": "dmg"
    }
  },
  "scripts": {
    "build": "theia build",
    "package": "build",
    "package:all": "build -mwl --x64",
    "postinstall": "npm run build && npm run dist",
    "dist": "npm run build && npm run package"
  },
  "keywords": [],
  "author": "typefox <[email protected]>",
  "license": "ISC",
  "bugs": {
    "url": "https://github.com/theia-ide/yangster/issues"
  },
  "homepage": "https://github.com/theia-ide/yangster#readme",
  "dependencies": {
    "@theia/core": "next",
    "@theia/editor": "next",
    "@theia/filesystem": "next",
    "@theia/git": "next",
    "@theia/languages": "next",
    "@theia/markers": "next",
    "@theia/monaco": "next",
    "@theia/navigator": "next",
    "@theia/preferences": "next",
    "@theia/process": "next",
    "@theia/terminal": "next",
    "@theia/typescript": "next",
    "@theia/workspace": "next",
    "theia-yang-extension": "0.1.2",
    "xterm": "^2.9.2"
  },
  "devDependencies": {
    "@theia/cli": "next",
    "electron-builder": "^19.30.2"
  }
}

Steps to build:

yarn

Key binding needed for next/previous page in the diagram when the diagram is bigger than the view area

Trying to fix #46, I encountered this issue.
I gave this a try: I added a dependency to the theia git extension in package.json. It builds fine but there's an exception in the frontend application, preventing it from starting:

(see the change here: marcdumais-work@5d4840d )

index.js:44 Error: Cannot apply @injectable decorator multiple times.
    at injectable.js:8
    at DecorateConstructor (Reflect.ts:1090)
    at Object.decorate (Reflect.ts:284)
    at _decorate (decorator_utils.js:42)
    at Object.decorate (decorator_utils.js:55)
    at Object.defineProperty.value (widget.ts:13)
    at __webpack_require__ (bootstrap 57bab4548ecc5c842def:688)
    at fn (bootstrap 57bab4548ecc5c842def:109)
    at Object.c (index.ts:8)
    at __webpack_require__ (bootstrap 57bab4548ecc5c842def:688)
module.exports.Promise.resolve.then.then.then.then.then.then.then.then.then.then.then.then.then.then.then.then.catch.reason @ index.js:44
Promise rejected (async)
(anonymous) @ index.js:41
__webpack_require__ @ bootstrap 57bab4548ecc5c842def:688
Object.defineProperty.value @ bootstrap 57bab4548ecc5c842def:789
(anonymous) @ bootstrap 57bab4548ecc5c842def:789

eclipse-theia/theia#1034

Looking at the outline view in Yangster, using the "mytest.yang" example source file, it seems that the view is only partially populated, having a single entry: "my-type". Bug?