thejkayway / m4apdx Goto Github PK

The home page and events pages should have H1s.

• The events page is one of the dynamically generated pages. It gets generated by gatsby at build time in src/gatsby/node/createPages.js. This happens by filling the template src/templates/events.js with data from contentful.

  • We have an existing styled component for h1 page titles (src/components/PageTitle.js). We can add this component to the <Container> component inside events.js as its first child.

• Content for the home page is entirely defined in contentful, adding a markdown h1 (e.g. # Example Header) there will create an html h1 onsite.

  • If we want to take away content editors' abilities to remove or change this we could modify src/templates/page.js, maybe to conditionally render a title pulled from contentful instead, but that sounds like a later thing to me

We should have a true <main> landmark on each page, not just <div>s with id=”main”

<style> is not allowed as a child of <div> in IE 10.

For the Get Involved form: We need a <fieldset> OR a role=”group” and a title.

Here’s an example of a form with fieldset: https://pauljadam.com/demos/fieldsetlegend.html

With screen reader (NVDA) running it isn’t clear what the blog preview boxes do. You have to listen to the very end to understand that they are links.

We can try the following solution: make the link apply only to the title; then add screen reader only text in a span inside the h2 element that says “go to full article” styled to be invisible with the clip method, as follows:

.sr-only {
    border: 0;
    clip: rect(0,0,0,0);
    height: 1px;
    margin: -1px;
    overflow: hidden;
    padding: 0;
    position: absolute;
    width: 1px;
}

An error on form submit sends the focus back to the form elements without warning and with no visible error message to explain what has happened.

Here’s an example of a good, accessible way to manage error messages: https://pauljadam.com/demos/form-error-top-inline.html

Bear in mind, appropriate error suggestions include:

• Indicating a required field has been left blank. OR
• Indicating the required format for the field in error. OR
• Indicating a range of valid values for the field in error.

On blog page, summary boxes, the date / time and length of read text is 3.9:1 at 16px. That’s too low. We can make the grey darker, or we can bump up the size to 24px.

SC 2.4.5 Multiple Ways

We should have at least 2 of the following:

• Site search
• Site map
• Table of contents
• List of related pages
• List of all available web pages

Our nav items count as a list of all available web pages.

A site search or sitemap would likely be the most functional of the above options, with a site search being a more differentiated way of navigating than the existing nav items (and thus preferable for fulfilling SC 2.4.5).