themadcreator / rabinfingerprint Goto Github PK

I m trying to generate fingerprint for a string. Below is the code snippet

    String s = "quick brown";
    Polynomial polynomial = Polynomial.createIrreducible(53);
    RabinFingerprintLong rabin = new RabinFingerprintLong(polynomial);
    rabin.pushBytes(s.getBytes());
    System.out.println(rabin.getFingerprintLong());
    System.out.println(Long.toString(rabin.getFingerprintLong(), 16));

I am always seeing new values for the same string that i m trying to finger print.
I was planning to use the fingerprint for detecting duplicate documents. Not sure if the code is working as expected or i am missing any thing here?

the pom.xml file requires a lot of massaging to compile. might be worth updating.

A hard upper limit to the time required to produce a random irreducible polynomial would be a nice feature. Someone auditing the code would have some questions about the current trial-and-error approach. It does not need to be fast but it does need to have a fixed upper bound.

public static Polynomial createIrreducible(int degree)

for (Long key : Iterables.limit(keys, fingersPerHand))
it is showing an error
The method limit is undefined for the type Iterables can you suggest any solution?

Since Guava is always in motion and there are many version conflicts in large enterprise environments it would be very cool if this dependency could be removed.

e.g. is it safe to use the same instance of RabinFingerprintLong from several threads?

I'm using your lib in my project :) and I'm wondering if you want to put it on a maven repo so that it is easier to integrate in other projects?

Handprint.buildAll() calls getPalm(), getAllFingers() and getHandFingers() apparently to fully compute each. But getPalm() fully consumes the InputSteam and then getAllFingers() fully consumes the InputSteam (which was now empty) and getHandFingers() calls getAllFingers() which makes the buildAll() call to getAllFingers() redundant.

If I'm right about the above this also means attempting to get the "palm" or the "fingers" in this class is mutually exclusive which I find counter intuitive based on the API.

I am trying to understand Rabin Fingerprinting via your project but it seems to me this code is just not right.